Closed Bug 1257005 Opened 4 years ago Closed 4 years ago

SpiderMonkey standalone builds using debug runtime because MOZ_NO_DEBUG_RTL isn't defined

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox48 fixed)

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: gps, Assigned: gps)

References

Details

Attachments

(2 files)

According to glandium, we should be using MOZ_NO_DEBUG_RTL in SM standalone builds. Because we're not using this, they're using the debug runtime, which isn't how our builds are supposed to work.
Assignee: nobody → gps
Status: NEW → ASSIGNED
This patch effectively synchronizes code from old-configure.in to
js/src/old-configure.in. Before, the top-level configure would set
MOZ_NO_DEBUG_RTL when using MOZ_MEMORY on Windows. This would get
inherited when the top-level configure invoked the js/src configure.

Since js/src's configure didn't have the same code, we never set
MOZ_NO_DEBUG_RTL when running a standalone js/src configure. This caused
the debug runtime to be used in standalone SpiderMonkey builds.

Review commit: https://reviewboard.mozilla.org/r/40289/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/40289/
Attachment #8730973 - Flags: review?(mh+mozilla)
Comment on attachment 8730973 [details]
MozReview Request: Bug 1257005 - Don't use debug runtime in standalone SpiderMonkey builds; r?glandium

https://reviewboard.mozilla.org/r/40289/#review36815
Attachment #8730973 - Flags: review?(mh+mozilla) → review+
This patch effectively synchronizes code from old-configure.in to
js/src/old-configure.in. Before, the top-level configure would set
MOZ_NO_DEBUG_RTL when using MOZ_MEMORY on Windows. This would get
inherited when the top-level configure invoked the js/src configure.

Since js/src's configure didn't have the same code, we never set
MOZ_NO_DEBUG_RTL when running a standalone js/src configure. This caused
the debug runtime to be used in standalone SpiderMonkey builds.

Review commit: https://reviewboard.mozilla.org/r/40321/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/40321/
Attachment #8731028 - Flags: review?(mh+mozilla)
Attachment #8731028 - Flags: review?(mh+mozilla) → review+
Comment on attachment 8731028 [details]
MozReview Request: Bug 1257005 - Don't use debug runtime in standalone SpiderMonkey builds; r=glandium

https://reviewboard.mozilla.org/r/40321/#review36853
Comment on attachment 8731028 [details]
MozReview Request: Bug 1257005 - Don't use debug runtime in standalone SpiderMonkey builds; r=glandium

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40321/diff/1-2/
Attachment #8731028 - Attachment description: MozReview Request: Bug 1257005 - Don't use debug runtime in standalone SpiderMonkey builds; r?glandium → MozReview Request: Bug 1257005 - Don't use debug runtime in standalone SpiderMonkey builds; r=glandium
https://hg.mozilla.org/mozilla-central/rev/290223936152
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.