1257037 - Eliminate worker descriptors

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

I think we should just aim to remove these.  For the handful of cases where we do have separate implementations we can introduce an abstract interface of some sort for the bindings to latch onto.

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

They're all gone now!  Boris, do you want to remove the cruft in Codegen.py?

(ni?me to ni?you later, sigh)

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: part 1. Remove the worker-descriptor-related complexity in getControllingCondition, since workerDesc.workers never tests true anymore

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. Remove isMaybeExposedIn, since it always returns true now

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: part 3. Remove filteredSignatures, since it's a no-op unless we're dealing with a worker descriptor

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: part 4. Remove the worker-only XXX comments from CGWrapGlobalMethod, since we never have worker descriptors for globals anyway

Comment 6

[Boris Zbarsky [:bzbarsky]]

Attachment: part 5. Remove remaining checks for worker descriptors from Codegen.py

Comment 7

[Boris Zbarsky [:bzbarsky]]

Attachment: part 6. Simplify the toBindingNamespace function now that there are no worker bindings

Comment 8

[Boris Zbarsky [:bzbarsky]]

Attachment: part 7. Make the binding Configuration a non-workers DescriptorProvider

Comment 9

[Boris Zbarsky [:bzbarsky]]

Attachment: part 8. Remove Configuration.getDescriptorProvider

Comment 10

[Boris Zbarsky [:bzbarsky]]

Attachment: part 9. Get rid of the concept of mainthread callbacks or worker callbacks; just codegen all the callbacks

Comment 11

[Boris Zbarsky [:bzbarsky]]

Attachment: part 10. Store only one descriptor per interface name in the configuration

Comment 12

[Boris Zbarsky [:bzbarsky]]

Attachment: part 11. Get rid of getRelevantProviders, since all the places that use it have a Configuration

Comment 13

[Boris Zbarsky [:bzbarsky]]

Attachment: part 12. Simplify CGRegisterWorkerBindings now that there are no more worker descriptors

Comment 14

[Boris Zbarsky [:bzbarsky]]

Attachment: part 13. Get rid of the concept of worker vs non-worker descriptors

Comment 15

[Boris Zbarsky [:bzbarsky]]

Attachment: part 14. Remove the now-unused skipGen bits from binding code

Comment 16

[Boris Zbarsky [:bzbarsky]]

Attachment: part 15. Get rid of the wantsXrays configuration annotation. Just set bindings to want Xrays if they're exposed in Window

Comment 17

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 8768914 [details] [diff] [review]
part 4.  Remove the worker-only XXX comments from CGWrapGlobalMethod, since we never have worker descriptors for globals anyway

Review of attachment 8768914 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bindings/Codegen.py
@@ -3805,5 @@
> -            fireOnNewGlobal = """// XXXkhuey can't do this yet until workers can lazy resolve.
> -// JS_FireOnNewGlobalObject(aCx, aReflector);
> -"""
> -        else:
> -            fireOnNewGlobal = ""

Hmm, I guess this moved somewhere else at some point.

Comment 18

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

r+++ would review again

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f2e423fbd09c
part 1.  Remove the worker-descriptor-related complexity in getControllingCondition, since workerDesc.workers never tests true anymore.  r=khuey
https://hg.mozilla.org/integration/mozilla-inbound/rev/0383f585a64f
part 2.  Remove isMaybeExposedIn, since it always returns true now.  r=khuey
https://hg.mozilla.org/integration/mozilla-inbound/rev/1d6e808cafc5
part 3.  Remove filteredSignatures, since it's a no-op unless we're dealing with a worker descriptor.  r=khuey
https://hg.mozilla.org/integration/mozilla-inbound/rev/5efc76268adf
part 4.  Remove the worker-only XXX comments from CGWrapGlobalMethod, since we never have worker descriptors for globals anyway.  r=khuey
https://hg.mozilla.org/integration/mozilla-inbound/rev/bd7880a96636
part 5.  Remove remaining checks for worker descriptors from Codegen.py.  r=khuey
https://hg.mozilla.org/integration/mozilla-inbound/rev/64424f160c3a
part 6.  Simplify the toBindingNamespace function now that there are no worker bindings.  r=khuey
https://hg.mozilla.org/integration/mozilla-inbound/rev/2de33eb0bb32
part 7.  Make the binding Configuration a non-workers DescriptorProvider.  r=khuey
https://hg.mozilla.org/integration/mozilla-inbound/rev/4c5ea0b7a3d1
part 8.  Remove Configuration.getDescriptorProvider.  r=khuey
https://hg.mozilla.org/integration/mozilla-inbound/rev/4565bfc8b866
part 9.  Get rid of the concept of mainthread callbacks or worker callbacks; just codegen all the callbacks.  r=khuey
https://hg.mozilla.org/integration/mozilla-inbound/rev/dfa4d5a42b52
part 10.  Store only one descriptor per interface name in the configuration.  r=khuey
https://hg.mozilla.org/integration/mozilla-inbound/rev/7b7cf5270426
part 11.  Get rid of getRelevantProviders, since all the places that use it have a Configuration.  r=khuey
https://hg.mozilla.org/integration/mozilla-inbound/rev/5014c7d22f2f
part 12.  Simplify CGRegisterWorkerBindings now that there are no more worker descriptors. r=khuey
https://hg.mozilla.org/integration/mozilla-inbound/rev/762c289ada58
part 13.  Get rid of the concept of worker vs non-worker descriptors.  r=khuey
https://hg.mozilla.org/integration/mozilla-inbound/rev/4082fdfd16fb
part 14.  Remove the now-unused skipGen bits from binding code.  r=khuey
https://hg.mozilla.org/integration/mozilla-inbound/rev/a92d0eec5c91
part 15.  Get rid of the wantsXrays configuration annotation.  Just set bindings to want Xrays if they're exposed in Window.  r=khuey

Comment 20

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f2e423fbd09c
https://hg.mozilla.org/mozilla-central/rev/0383f585a64f
https://hg.mozilla.org/mozilla-central/rev/1d6e808cafc5
https://hg.mozilla.org/mozilla-central/rev/5efc76268adf
https://hg.mozilla.org/mozilla-central/rev/bd7880a96636
https://hg.mozilla.org/mozilla-central/rev/64424f160c3a
https://hg.mozilla.org/mozilla-central/rev/2de33eb0bb32
https://hg.mozilla.org/mozilla-central/rev/4c5ea0b7a3d1
https://hg.mozilla.org/mozilla-central/rev/4565bfc8b866
https://hg.mozilla.org/mozilla-central/rev/dfa4d5a42b52
https://hg.mozilla.org/mozilla-central/rev/7b7cf5270426
https://hg.mozilla.org/mozilla-central/rev/5014c7d22f2f
https://hg.mozilla.org/mozilla-central/rev/762c289ada58
https://hg.mozilla.org/mozilla-central/rev/4082fdfd16fb
https://hg.mozilla.org/mozilla-central/rev/a92d0eec5c91

Comment 21

[Boris Zbarsky [:bzbarsky]]

Updated MDN to remove the one mention of worker descriptors on the webidl bindings page (for Throws/GetterThrows/SetterThrows).