Closed Bug 1257042 Opened 5 years ago Closed 5 years ago

De-workerify push events

Categories

(Core :: DOM: Workers, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: khuey, Assigned: khuey)

References

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
Remove the worker namespacing and the worker descriptors.
Attachment #8731010 - Flags: review?(bzbarsky)
Comment on attachment 8731010 [details] [diff] [review]
Patch

r=me, but this didn't actually remove the worker namespacing, right?
Attachment #8731010 - Flags: review?(bzbarsky) → review+
Yes, you're right of course. I just got used to typing that in the other bugs I filed :P
Backed out for bustage.

Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/6d67d7bd2c78

Push with bustage: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=06101225c145
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=23948520&repo=mozilla-inbound


c:\builds\moz2_slave\m-in-w32-000000000000000000000\build\src\obj-firefox\dist\include\mozilla/dom/ServiceWorkerEvents.h(32) : error C2220: warning treated as error - no 'object' file generated
c:\builds\moz2_slave\m-in-w32-000000000000000000000\build\src\obj-firefox\dist\include\mozilla\dom\ServiceWorkerEvents.h(32) : error C2220: warning treated as error - no 'object' file generated
Flags: needinfo?(khuey)
Flags: needinfo?(khuey)
https://hg.mozilla.org/mozilla-central/rev/75e29a228b80
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Depends on: 1258034
You need to log in before you can comment on or make changes to this bug.