Closed
Bug 1257051
Opened 8 years ago
Closed 8 years ago
Use separate target triplets for iOS and OSX
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox48 fixed)
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file)
No description provided.
Assignee | ||
Comment 1•8 years ago
|
||
This aligns with the triplets used by clang/llvm. Technically, this won't break iOS builds still using -darwin triplets until we move MOZ_IOS_SDK to moz.configure and actively reject non iOS targets with the iOS sdk. Also allow to distinguish iOS and OSX with target.os. Review commit: https://reviewboard.mozilla.org/r/40317/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/40317/
Attachment #8731018 -
Flags: review?(ted)
Assignee | ||
Comment 2•8 years ago
|
||
Comment on attachment 8731018 [details] MozReview Request: Bug 1257051 - Use separate target triplets for iOS and OSX Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40317/diff/1-2/
Comment 3•8 years ago
|
||
Comment on attachment 8731018 [details] MozReview Request: Bug 1257051 - Use separate target triplets for iOS and OSX https://reviewboard.mozilla.org/r/40317/#review36911 ::: build/moz.configure/init.configure:367 (Diff revision 2) > elif os.startswith('darwin'): > - canonical_os = canonical_kernel = 'Darwin' > + canonical_kernel = 'Darwin' > + canonical_os = 'OSX' > + elif os.startswith('ios'): > + canonical_kernel = 'Darwin' > + canonical_os = 'iOS' This is definitely more sensible than what we currently have.
Attachment #8731018 -
Flags: review?(ted) → review+
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/bea1d2b75313
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•