Reftest doesn't work on Windows

RESOLVED FIXED in Firefox 48

Status

Testing
Reftest
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: xidorn, Assigned: xidorn)

Tracking

unspecified
mozilla48
Unspecified
Windows
Points:
---

Firefox Tracking Flags

(firefox48 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
There are two issues with running reftest on Windows: one is the crash described in bug 1256257, the other is that the path of the extension has a mix of slashes, which cannot be handled properly for the JavaScript code to install the extension. This bug is mainly for the second one.
(Assignee)

Comment 1

2 years ago
Created attachment 8731074 [details]
MozReview Request: Bug 1257099 - Normalize the path of extensions for reftest.

Review commit: https://reviewboard.mozilla.org/r/40343/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/40343/
Attachment #8731074 - Flags: review?(jmaher)
(Assignee)

Updated

2 years ago
Assignee: nobody → quanxunzhen
(Assignee)

Comment 2

2 years ago
I'm not really sure why it worked, and why the infra doesn't catch anything... but it doesn't work for me locally today, at least.
Comment on attachment 8731074 [details]
MozReview Request: Bug 1257099 - Normalize the path of extensions for reftest.

https://reviewboard.mozilla.org/r/40343/#review36915

::: layout/tools/reftest/reftestcommandline.py:294
(Diff revision 1)
>              if self.build_obj is not None:
> -                options.specialPowersExtensionPath = os.path.join(self.build_obj.topobjdir, "_tests",
> +                specialPowersExtensionPath = os.path.join(self.build_obj.topobjdir, "_tests",
> -                                                                  "reftest", "specialpowers")
> +                                                          "reftest", "specialpowers")
>              else:
> -                options.specialPowersExtensionPath = os.path.join(
> -                    here, "specialpowers")
> +                specialPowersExtensionPath = os.path.join(here, "specialpowers")
> +            options.specialPowersExtensionPath = os.path.normpath(specialPowersExtensionPath)

why are you removing specialPowersExtensionPath?
Attachment #8731074 - Flags: review?(jmaher)
(Assignee)

Comment 4

2 years ago
https://reviewboard.mozilla.org/r/40343/#review36915

> why are you removing specialPowersExtensionPath?

Am I removing anything? I don't think so.
Comment on attachment 8731074 [details]
MozReview Request: Bug 1257099 - Normalize the path of extensions for reftest.

https://reviewboard.mozilla.org/r/40343/#review36943

my bad, I get really confused with the colors used in mozreview and misread the patch.
Attachment #8731074 - Flags: review+

Comment 7

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ce9c0d631b58
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Duplicate of this bug: 1257144
You need to log in before you can comment on or make changes to this bug.