Update comm-central for PLDHashTable changes in bug 1253085

RESOLVED FIXED in Thunderbird 48.0

Status

--
critical
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: njn, Assigned: njn)

Tracking

unspecified
Thunderbird 48.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Bug 1253085 changed PLDHashTableOps, by removing the |PLDHashTable*| argument to the hashKey and matchEntry entries.

Here's a corresponding patch for comm-central.
(Assignee)

Comment 1

3 years ago
Created attachment 8731115 [details] [diff] [review]
Update comm-central to handle removal of the |PLDHashTable*| argument from PLDHash{HashKey,MatchEntry}

This compiles but I haven't done any testing. It's a pretty simple patch.
Attachment #8731115 - Flags: review?(rkent)
(Assignee)

Updated

3 years ago
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED

Comment 2

3 years ago
Thanks njn, I'll look at this once the dependent patch has landed.

Comment 3

3 years ago
Comment on attachment 8731115 [details] [diff] [review]
Update comm-central to handle removal of the |PLDHashTable*| argument from PLDHash{HashKey,MatchEntry}

Review of attachment 8731115 [details] [diff] [review]:
-----------------------------------------------------------------

I can't really check that this compile because c-c is broken for other reasons, but it looks good to me so rs=me.
Attachment #8731115 - Flags: review?(rkent) → review+

Comment 4

3 years ago
I won't land this, but just set checkin-needed so that those who are working on getting the tree green can land it when appropriate.
Keywords: checkin-needed

Comment 5

3 years ago
https://hg.mozilla.org/comm-central/rev/143168d38573cc75f3b03813c1de5b7c3376b231
Bug 1257110 - Update comm-central to handle removal of the |PLDHashTable*| argument from PLDHash{HashKey,MatchEntry}. r=rkent. a=bustage fix CLOSED TREE DONTBUILD

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 48.0
You need to log in before you can comment on or make changes to this bug.