Closed Bug 1257110 Opened 9 years ago Closed 9 years ago

Update comm-central for PLDHashTable changes in bug 1253085

Categories

(MailNews Core :: Backend, defect)

defect
Not set
critical

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 48.0

People

(Reporter: n.nethercote, Assigned: n.nethercote)

References

Details

Attachments

(1 file)

Bug 1253085 changed PLDHashTableOps, by removing the |PLDHashTable*| argument to the hashKey and matchEntry entries. Here's a corresponding patch for comm-central.
This compiles but I haven't done any testing. It's a pretty simple patch.
Attachment #8731115 - Flags: review?(rkent)
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
Thanks njn, I'll look at this once the dependent patch has landed.
Comment on attachment 8731115 [details] [diff] [review] Update comm-central to handle removal of the |PLDHashTable*| argument from PLDHash{HashKey,MatchEntry} Review of attachment 8731115 [details] [diff] [review]: ----------------------------------------------------------------- I can't really check that this compile because c-c is broken for other reasons, but it looks good to me so rs=me.
Attachment #8731115 - Flags: review?(rkent) → review+
I won't land this, but just set checkin-needed so that those who are working on getting the tree green can land it when appropriate.
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/143168d38573cc75f3b03813c1de5b7c3376b231 Bug 1257110 - Update comm-central to handle removal of the |PLDHashTable*| argument from PLDHash{HashKey,MatchEntry}. r=rkent. a=bustage fix CLOSED TREE DONTBUILD
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 48.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: