Closed
Bug 1257128
Opened 8 years ago
Closed 8 years ago
Minimize nsIAtom and nsIAtomService
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: n.nethercote, Assigned: n.nethercote)
References
Details
Attachments
(4 files)
3.47 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
1.66 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
1.04 KB,
patch
|
tbsaunde
:
review+
|
Details | Diff | Splinter Review |
3.46 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
Both nsIAtom and nsIAtomService have unused |noscript| methods. My understanding is that these can be removed without worrying about add-ons.
Assignee | ||
Comment 1•8 years ago
|
||
It's only used in tests.
Attachment #8731176 -
Flags: review?(nfroyd)
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•8 years ago
|
||
Attachment #8731178 -
Flags: review?(nfroyd)
Assignee | ||
Comment 3•8 years ago
|
||
Attachment #8731179 -
Flags: review?(tbsaunde+mozbugs)
Assignee | ||
Comment 4•8 years ago
|
||
Attachment #8731180 -
Flags: review?(nfroyd)
Assignee | ||
Comment 5•8 years ago
|
||
Try looks good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f187bb4c8e8c
Updated•8 years ago
|
Attachment #8731179 -
Flags: review?(tbsaunde+mozbugs) → review+
Assignee | ||
Updated•8 years ago
|
Updated•8 years ago
|
Attachment #8731176 -
Flags: review?(nfroyd) → review+
Updated•8 years ago
|
Attachment #8731178 -
Flags: review?(nfroyd) → review+
Updated•8 years ago
|
Attachment #8731180 -
Flags: review?(nfroyd) → review+
Assignee | ||
Comment 6•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/0eba208813c315fac76f9825cb1385c7432c1f44 Bug 1257128 (part 1) - Remove nsIAtom.equalsUTF8. r=froydnj. https://hg.mozilla.org/integration/mozilla-inbound/rev/1eee02156b68f5171ef8d087ed5bb614339b053a Bug 1257128 (part 2) - Remove nsIAtomService.get{,Permanent}AtomUTF8. r=froydnj. https://hg.mozilla.org/integration/mozilla-inbound/rev/59fe9a7b94c7e4ced362db3fc46295dec48760a8 Bug 1257128 (part 3) - Remove unused createAtom() function in a test. r=tbsaunde. https://hg.mozilla.org/integration/mozilla-inbound/rev/d1ae745b7e3fcb2dbeea4814fa4f907160b1d0e9 Bug 1257128 (part 4) - Remove unused nsIAtomService references in toolkit/. r=froydnj.
Comment 7•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/0eba208813c3 https://hg.mozilla.org/mozilla-central/rev/1eee02156b68 https://hg.mozilla.org/mozilla-central/rev/59fe9a7b94c7 https://hg.mozilla.org/mozilla-central/rev/d1ae745b7e3f
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•