Minimize nsIAtom and nsIAtomService

RESOLVED FIXED in Firefox 48

Status

()

Core
XPCOM
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: njn, Assigned: njn)

Tracking

(Blocks: 1 bug)

Trunk
mozilla48
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox48 fixed)

Details

Attachments

(4 attachments)

(Assignee)

Description

2 years ago
Both nsIAtom and nsIAtomService have unused |noscript| methods. My understanding is that these can be removed without worrying about add-ons.
(Assignee)

Comment 1

2 years ago
Created attachment 8731176 [details] [diff] [review]
(part 1) - Remove nsIAtom.equalsUTF8

It's only used in tests.
Attachment #8731176 - Flags: review?(nfroyd)
(Assignee)

Updated

2 years ago
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
(Assignee)

Comment 2

2 years ago
Created attachment 8731178 [details] [diff] [review]
(part 2) - Remove nsIAtomService.get{,Permanent}AtomUTF8
Attachment #8731178 - Flags: review?(nfroyd)
(Assignee)

Comment 3

2 years ago
Created attachment 8731179 [details] [diff] [review]
(part 3) - Remove unused createAtom() function in a test
Attachment #8731179 - Flags: review?(tbsaunde+mozbugs)
(Assignee)

Comment 4

2 years ago
Created attachment 8731180 [details] [diff] [review]
(part 4) - Remove unused nsIAtomService references in toolkit/
Attachment #8731180 - Flags: review?(nfroyd)
(Assignee)

Comment 5

2 years ago
Try looks good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f187bb4c8e8c
Attachment #8731179 - Flags: review?(tbsaunde+mozbugs) → review+
(Assignee)

Updated

2 years ago
Blocks: 1257126
No longer depends on: 1257126
(Assignee)

Updated

2 years ago
Blocks: 1257402
Attachment #8731176 - Flags: review?(nfroyd) → review+
Attachment #8731178 - Flags: review?(nfroyd) → review+
Attachment #8731180 - Flags: review?(nfroyd) → review+
(Assignee)

Comment 6

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/0eba208813c315fac76f9825cb1385c7432c1f44
Bug 1257128 (part 1) - Remove nsIAtom.equalsUTF8. r=froydnj.

https://hg.mozilla.org/integration/mozilla-inbound/rev/1eee02156b68f5171ef8d087ed5bb614339b053a
Bug 1257128 (part 2) - Remove nsIAtomService.get{,Permanent}AtomUTF8. r=froydnj.

https://hg.mozilla.org/integration/mozilla-inbound/rev/59fe9a7b94c7e4ced362db3fc46295dec48760a8
Bug 1257128 (part 3) - Remove unused createAtom() function in a test. r=tbsaunde.

https://hg.mozilla.org/integration/mozilla-inbound/rev/d1ae745b7e3fcb2dbeea4814fa4f907160b1d0e9
Bug 1257128 (part 4) - Remove unused nsIAtomService references in toolkit/. r=froydnj.

Comment 7

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/0eba208813c3
https://hg.mozilla.org/mozilla-central/rev/1eee02156b68
https://hg.mozilla.org/mozilla-central/rev/59fe9a7b94c7
https://hg.mozilla.org/mozilla-central/rev/d1ae745b7e3f
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox48: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48

Updated

2 years ago
See Also: → bug 1259495

Updated

2 years ago
Depends on: 1259495
You need to log in before you can comment on or make changes to this bug.