Closed
Bug 1257137
Opened 8 years ago
Closed 8 years ago
downloads.[pause/resume/cancel] are missing a try/catch around DownloadMap.fromId()
Categories
(WebExtensions :: Untriaged, defect)
WebExtensions
Untriaged
Tracking
(firefox48 fixed)
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: scolville, Assigned: aswan)
Details
(Whiteboard: [downloads])
Attachments
(1 file)
DownloadMap.fromId() throws if the id is non-existent so a try/catch is needed.
Assignee | ||
Updated•8 years ago
|
Iteration: --- → 48.1 - Mar 21
Whiteboard: [downloads]
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/42821/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/42821/
Attachment #8735520 -
Flags: review?(kmaglione+bmo)
Updated•8 years ago
|
Attachment #8735520 -
Flags: review?(kmaglione+bmo) → review+
Comment 2•8 years ago
|
||
Comment on attachment 8735520 [details] MozReview Request: Bug 1257137 Handle bad args in downloads.{pause,resume,cancel} r?kmag https://reviewboard.mozilla.org/r/42821/#review39277
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 4•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4772ee550675
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Updated•6 years ago
|
Product: Toolkit → WebExtensions
You need to log in
before you can comment on or make changes to this bug.
Description
•