Closed Bug 1257137 Opened 8 years ago Closed 8 years ago

downloads.[pause/resume/cancel] are missing a try/catch around DownloadMap.fromId()

Categories

(WebExtensions :: Untriaged, defect)

defect
Not set
normal

Tracking

(firefox48 fixed)

RESOLVED FIXED
mozilla48
Iteration:
48.1 - Mar 21
Tracking Status
firefox48 --- fixed

People

(Reporter: scolville, Assigned: aswan)

Details

(Whiteboard: [downloads])

Attachments

(1 file)

DownloadMap.fromId() throws if the id is non-existent so a try/catch is needed.
Iteration: --- → 48.1 - Mar 21
Whiteboard: [downloads]
Attachment #8735520 - Flags: review?(kmaglione+bmo) → review+
Comment on attachment 8735520 [details]
MozReview Request: Bug 1257137 Handle bad args in downloads.{pause,resume,cancel} r?kmag

https://reviewboard.mozilla.org/r/42821/#review39277
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/4772ee550675
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.