Closed
Bug 1257139
Opened 9 years ago
Closed 9 years ago
some freebl coverity fixes
Categories
(NSS :: Libraries, defect)
NSS
Libraries
Tracking
(firefox48 affected)
RESOLVED
FIXED
3.24
| Tracking | Status | |
|---|---|---|
| firefox48 | --- | affected |
People
(Reporter: franziskus, Assigned: franziskus)
References
(Blocks 1 open bug)
Details
(Keywords: coverity, Whiteboard: CID 1356341, CID 1356340)
Attachments
(1 file)
|
1.72 KB,
patch
|
ttaubert
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•9 years ago
|
||
the second part is straight forward. For the first part I'm not sure if that's was typo or if there's a logic behind it I (and coverity) don't understand. If in doubt, ask Bob.
Attachment #8731187 -
Flags: review?(ttaubert)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8731187 [details] [diff] [review]
freebl-coverity.patch
Review of attachment 8731187 [details] [diff] [review]:
-----------------------------------------------------------------
*pVfy == NULL seems the right thing to check, we otherwise might deref it in the condition multiple times, and also further down when calling makeGfromIndex().
Attachment #8731187 -
Flags: review?(ttaubert) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.24
You need to log in
before you can comment on or make changes to this bug.
Description
•