1257152 - hg.mozilla.org on release is broken due to backout message referencing in invalid node

Status: RESOLVED FIXED

(Developer Services :: Mercurial: hg.mozilla.org, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

https://hg.mozilla.org/releases/mozilla-release/shortlog

An error occurred while processing your request
unknown revision 'e3218dde2b31' 

m-b is not affected

Comment 1

[Gregory Szorc [:gps]]

This is a wonky bug. I'm not seeing stacks on the server, but I have a hunch this has something to do with the code that does backout detection.

Comment 2

[Gregory Szorc [:gps]]

Attachment: MozReview Request: hgmo: add test reproducing node lookup failure (bug 1257152); r?dminor

My hunch is correct: a backout message referencing an invalid node
results in an error.

Review commit: https://reviewboard.mozilla.org/r/40539/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/40539/

Comment 3

[Gregory Szorc [:gps]]

Attachment: MozReview Request: hgmo: catch proper exception when looking up changeset (bug 1257152); r?dminor

LookupError is raised by revlogs. RepoLookupError is raised when looking
up changesets. Derp.

Review commit: https://reviewboard.mozilla.org/r/40541/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/40541/

Comment 4

[Gregory Szorc [:gps]]

https://hg.mozilla.org/releases/mozilla-release/rev/ac70bcc23a65 is the changeset that triggered this. The node it is referencing is not on mozilla-release at this time. The proper node should have been c728f7d9d0dc (not e3218dde2b31). My guess is the changeset was grafted from the repo where we initially performed the backout (possibly beta).

Comment 5

[Dan Minor [:dminor]]

Comment on attachment 8731390 [details]
MozReview Request: hgmo: add test reproducing node lookup failure (bug 1257152); r?dminor

https://reviewboard.mozilla.org/r/40539/#review37087

Comment 6

[Dan Minor [:dminor]]

Comment on attachment 8731391 [details]
MozReview Request: hgmo: catch proper exception when looking up changeset (bug 1257152); r?dminor

https://reviewboard.mozilla.org/r/40541/#review37089

Comment 7

[Gregory Szorc [:gps]]

This is deployed. It make take a few minutes for the servers to pick up the code changes and stop throwing.