Closed Bug 1257152 Opened 5 years ago Closed 5 years ago

hg.mozilla.org on release is broken due to backout message referencing in invalid node

Categories

(Developer Services :: Mercurial: hg.mozilla.org, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Sylvestre, Assigned: gps)

Details

Attachments

(2 files)

https://hg.mozilla.org/releases/mozilla-release/shortlog

An error occurred while processing your request
unknown revision 'e3218dde2b31' 

m-b is not affected
This is a wonky bug. I'm not seeing stacks on the server, but I have a hunch this has something to do with the code that does backout detection.
Assignee: nobody → gps
Status: NEW → ASSIGNED
Summary: hg.mozilla.org on release is broken → hg.mozilla.org on release is broken due to backout message referencing in invalid node
My hunch is correct: a backout message referencing an invalid node
results in an error.

Review commit: https://reviewboard.mozilla.org/r/40539/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/40539/
Attachment #8731390 - Flags: review?(dminor)
LookupError is raised by revlogs. RepoLookupError is raised when looking
up changesets. Derp.

Review commit: https://reviewboard.mozilla.org/r/40541/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/40541/
Attachment #8731391 - Flags: review?(dminor)
https://hg.mozilla.org/releases/mozilla-release/rev/ac70bcc23a65 is the changeset that triggered this. The node it is referencing is not on mozilla-release at this time. The proper node should have been c728f7d9d0dc (not e3218dde2b31). My guess is the changeset was grafted from the repo where we initially performed the backout (possibly beta).
Comment on attachment 8731390 [details]
MozReview Request: hgmo: add test reproducing node lookup failure (bug 1257152); r?dminor

https://reviewboard.mozilla.org/r/40539/#review37087
Attachment #8731390 - Flags: review?(dminor) → review+
Comment on attachment 8731391 [details]
MozReview Request: hgmo: catch proper exception when looking up changeset (bug 1257152); r?dminor

https://reviewboard.mozilla.org/r/40541/#review37089
Attachment #8731391 - Flags: review?(dminor) → review+
This is deployed. It make take a few minutes for the servers to pick up the code changes and stop throwing.
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.