Closed Bug 1257178 Opened 5 years ago Closed 5 years ago

this._input is undefined when running gcli tests

Categories

(DevTools Graveyard :: Graphic Commandline and Toolbar, defect)

defect
Not set
normal

Tracking

(firefox48 fixed)

RESOLVED FIXED
Firefox 48
Tracking Status
firefox48 --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

Details

Attachments

(1 file)

There is some exceptions happening in devtools/client/commandline/test/browser_cmd_commands.js and some other tests since I landed bug 1248601.

https://treeherder.mozilla.org/#/jobs?repo=fx-team&revision=220192149ce4
http://archive.mozilla.org/pub/firefox/tinderbox-builds/fx-team-linux64-debug/1458117646/fx-team_ubuntu64_vm-debug_test-mochitest-devtools-chrome-7-bm116-tests1-linux64-build26.txt.gz
04:27:11     INFO -  JavaScript error: resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/shared/developer-toolbar.js, line 508: TypeError: this._input is undefined
04:27:12     INFO -  --DOCSHELL 0x7ff318f78800 == 10 [pid = 1947] [id = 22]

That's most likely before the toolbar is hidden early or hidden while it is in process of being show...
Attached patch patch v1Splinter Review
Attachment #8731247 - Flags: review?(jwalker)
Attachment #8731247 - Flags: review?(jwalker) → review+
https://hg.mozilla.org/integration/fx-team/rev/c1f0341f9055edd241c8de6663aab14209a766b5
Bug 1257178 - Prevent "this._input is undefined" exception when developer toolbar is hidden early. r=jwalker
https://hg.mozilla.org/mozilla-central/rev/c1f0341f9055
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.