Closed
Bug 1257211
Opened 9 years ago
Closed 9 years ago
Intermittent Crash [@ mozilla::OffTheBooksMutex::Lock] with H264 decoding
Categories
(Core :: Audio/Video: Playback, defect)
Tracking
()
RESOLVED
FIXED
mozilla48
People
(Reporter: decoder, Assigned: jya)
References
Details
(Keywords: crash, testcase, Whiteboard: [fuzzblocker])
Crash Data
Attachments
(3 files)
9.59 KB,
text/plain
|
Details | |
977.01 KB,
application/octet-stream
|
Details | |
58 bytes,
text/x-review-board-request
|
mozbugz
:
review+
ritu
:
approval-mozilla-aurora+
|
Details |
The attached testcase crashes on mozilla-inbound revision f30fc906416f (build with --enable-optimize --disable-debug --enable-address-sanitizer).
For detailed crash information, see attachment.
To reproduce the issue, you can run the testcase through the "MediaDataDecoder.H264" gtest. Example STR:
1. Change into objdir/dist/bin of your Firefox build
2. Place attached testcase into objdir, keep the name "gizmo.mp4"
3. Run: GTEST_FILTER=MediaDataDecoder.H264 MOZ_RUN_GTEST=1 ./firefox -unittest
Unfortunately the test is intermittent. The attached sample reproduces fairly well for me (at least 1 of 10 runs). Fixing this issue is quite important since it causes a lot of crashes in fuzzing. Marking as fuzzblocker and stopping this type of fuzzing until this crash is fixed.
Reporter | ||
Comment 1•9 years ago
|
||
Reporter | ||
Comment 2•9 years ago
|
||
Assignee | ||
Comment 3•9 years ago
|
||
Which version of ffmpeg are you using?
Can you reproduce with the latest? (3.0)
Assignee | ||
Comment 4•9 years ago
|
||
Seems to me that this bug is within Benchmark class and not in the decoder or demuxer.
My guess is that it's possible a task is dispatched at the same time the task queue is being shutdown.
Now I don't know if we simply work around In Benchmark by making mFinished a mutable and testing it before dispatching the task. Or there could be an issue in TaskQueues themselves.
Reporter | ||
Comment 5•9 years ago
|
||
I'm just using what is in mozilla-inbound. I can try a fix if you have one :)
Assignee | ||
Comment 6•9 years ago
|
||
(In reply to Christian Holler (:decoder) from comment #5)
> I'm just using what is in mozilla-inbound. I can try a fix if you have one :)
we don't ship ffmpeg. So if you are decoding h264, you must have ffmpeg installed somewhere.
Assignee | ||
Comment 7•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/40673/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/40673/
Attachment #8731510 -
Flags: review?(gsquelart)
Assignee: nobody → jyavenard
Comment on attachment 8731510 [details]
MozReview Request: Bug 1257211: Exit early if already shutting down. r?gerald
https://reviewboard.mozilla.org/r/40673/#review37183
Attachment #8731510 -
Flags: review?(gsquelart) → review+
Comment 10•9 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Assignee | ||
Comment 11•9 years ago
|
||
Comment on attachment 8731510 [details]
MozReview Request: Bug 1257211: Exit early if already shutting down. r?gerald
Patch request is for all changeset
Approval Request Comment
[Feature/regressing bug #]: 1256626
[User impact if declined]: We aim to enable VP9 to all machines fast enough to support it. It would also reduce issues seen with h264 hardware decoder.
[Describe test coverage new/current, TreeHerder]: in central for a few weeks.
[Risks and why]: none, prevent crash
[String/UUID change made/needed]: none
Attachment #8731510 -
Flags: approval-mozilla-aurora?
status-firefox47:
--- → affected
Comment on attachment 8731510 [details]
MozReview Request: Bug 1257211: Exit early if already shutting down. r?gerald
Media team wants to enable VP9 on faster machines in 47, I have been told this is mostly a staged rollout and quality is acceptable. Aurora47+
Attachment #8731510 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 13•9 years ago
|
||
bugherder uplift |
![]() |
||
Comment 14•8 years ago
|
||
crash on fennec 49.0.
crash ID: ebda8ad2-b5b3-40af-99b0-f13802161009
crash stats: https://crash-stats.mozilla.com/report/index/ebda8ad2-b5b3-40af-99b0-f13802161009
You need to log in
before you can comment on or make changes to this bug.
Description
•