Closed
Bug 1257217
Opened 6 years ago
Closed 6 years ago
Remove unused method GeckoPreferences.broadcastPrefAction()
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox48 fixed)
RESOLVED
FIXED
Firefox 48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: sebastian, Assigned: dineshp, Mentored)
Details
Attachments
(1 file)
2.25 KB,
patch
|
sebastian
:
review+
|
Details | Diff | Splinter Review |
The broadcastPrefAction() method of the GeckoPreferences class is unused. To start, set up a build environment - you can see the instructions here: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_for_Android_build To fix this bug, you need to remove this method: https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/preferences/GeckoPreferences.java?from=GeckoPreferences.java#991-1008 Then, you'll need to create a patch to upload - see https://developer.mozilla.org/en-US/docs/Mercurial/Using_Mercurial#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F
Reporter | ||
Comment 2•6 years ago
|
||
Someone on IRC ("BlueCoolant") asked if he can work on this bug too. Is this you? Usually we assign bugs after the first patch has been uploaded. :)
Flags: needinfo?(s.kaspari)
Assignee | ||
Comment 3•6 years ago
|
||
I removed the broadcastPrefAction() method.
Attachment #8731551 -
Flags: review?(s.kaspari)
Reporter | ||
Updated•6 years ago
|
Assignee: nobody → dpdineshp2
Status: NEW → ASSIGNED
looks like the definition of the following functions have been commented out and are unused. -> broadcastHealthReportUploadPref(final Context context, final boolean value) -> broadcastHealthReportUploadPref(final Context context) -> broadcastHealthReportPrune(final Context context) Can I remove these?
Flags: needinfo?(s.kaspari)
Reporter | ||
Comment 5•6 years ago
|
||
(In reply to vinayak from comment #4) > Can I remove these? Let's look at them separately. The code is commented out (we had to remove FHR) but the code calling them still exists.
Flags: needinfo?(s.kaspari)
Reporter | ||
Comment 6•6 years ago
|
||
Comment on attachment 8731551 [details] [diff] [review] bug1257217.patch Review of attachment 8731551 [details] [diff] [review]: ----------------------------------------------------------------- LGTM.
Attachment #8731551 -
Flags: review?(s.kaspari) → review+
Reporter | ||
Updated•6 years ago
|
Flags: needinfo?(s.kaspari)
Reporter | ||
Comment 7•6 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/7909460567c8f6c05c82d2675ddf6ee970ef1a21 Bug 1257217 - Remove unused method GeckoPreferences.broadcastPrefAction(). r=sebastian
Reporter | ||
Updated•6 years ago
|
Flags: needinfo?(s.kaspari)
Comment 8•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/7909460567c8
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Updated•2 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•