Closed Bug 1257217 Opened 4 years ago Closed 4 years ago

Remove unused method GeckoPreferences.broadcastPrefAction()

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 48
Tracking Status
firefox48 --- fixed

People

(Reporter: sebastian, Assigned: dineshp, Mentored)

Details

Attachments

(1 file)

Hi, I would like work on this bug.
Flags: needinfo?(s.kaspari)
Someone on IRC ("BlueCoolant") asked if he can work on this bug too. Is this you?

Usually we assign bugs after the first patch has been uploaded. :)
Flags: needinfo?(s.kaspari)
Attached patch bug1257217.patchSplinter Review
I removed the broadcastPrefAction() method.
Attachment #8731551 - Flags: review?(s.kaspari)
Assignee: nobody → dpdineshp2
Status: NEW → ASSIGNED
looks like the definition of the following functions have been commented out and are unused.
-> broadcastHealthReportUploadPref(final Context context, final boolean value)
-> broadcastHealthReportUploadPref(final Context context)
-> broadcastHealthReportPrune(final Context context) 

Can I remove these?
Flags: needinfo?(s.kaspari)
(In reply to vinayak from comment #4)
> Can I remove these?

Let's look at them separately. The code is commented out (we had to remove FHR) but the code calling them still exists.
Flags: needinfo?(s.kaspari)
Comment on attachment 8731551 [details] [diff] [review]
bug1257217.patch

Review of attachment 8731551 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #8731551 - Flags: review?(s.kaspari) → review+
Flags: needinfo?(s.kaspari)
https://hg.mozilla.org/integration/fx-team/rev/7909460567c8f6c05c82d2675ddf6ee970ef1a21
Bug 1257217 - Remove unused method GeckoPreferences.broadcastPrefAction(). r=sebastian
Flags: needinfo?(s.kaspari)
https://hg.mozilla.org/mozilla-central/rev/7909460567c8
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
You need to log in before you can comment on or make changes to this bug.