1257217 - Remove unused method GeckoPreferences.broadcastPrefAction()

Status: RESOLVED FIXED

(Firefox for Android :: General, defect)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

The broadcastPrefAction() method of the GeckoPreferences class is unused.

To start, set up a build environment - you can see the instructions here:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_for_Android_build

To fix this bug, you need to remove this method:
https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/preferences/GeckoPreferences.java?from=GeckoPreferences.java#991-1008


Then, you'll need to create a patch to upload - see
https://developer.mozilla.org/en-US/docs/Mercurial/Using_Mercurial#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F

Comment 1

[vinayak]

Hi, I would like work on this bug.

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

Someone on IRC ("BlueCoolant") asked if he can work on this bug too. Is this you?

Usually we assign bugs after the first patch has been uploaded. :)

Comment 3

[Dinesh Polathula (:dineshp)]

Attachment: bug1257217.patch

I removed the broadcastPrefAction() method.

Comment 4

[vinayak]

looks like the definition of the following functions have been commented out and are unused.
-> broadcastHealthReportUploadPref(final Context context, final boolean value)
-> broadcastHealthReportUploadPref(final Context context)
-> broadcastHealthReportPrune(final Context context) 

Can I remove these?

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to vinayak from comment #4)
> Can I remove these?

Let's look at them separately. The code is commented out (we had to remove FHR) but the code calling them still exists.

Comment 6

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8731551 [details] [diff] [review]
bug1257217.patch

Review of attachment 8731551 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

Comment 7

[Sebastian Kaspari (:sebastian; :pocmo)]

https://hg.mozilla.org/integration/fx-team/rev/7909460567c8f6c05c82d2675ddf6ee970ef1a21
Bug 1257217 - Remove unused method GeckoPreferences.broadcastPrefAction(). r=sebastian

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7909460567c8