Closed Bug 1257217 Opened 5 years ago Closed 5 years ago
Remove unused method Gecko
Preferences .broadcast Pref Action()
The broadcastPrefAction() method of the GeckoPreferences class is unused. To start, set up a build environment - you can see the instructions here: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_for_Android_build To fix this bug, you need to remove this method: https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/preferences/GeckoPreferences.java?from=GeckoPreferences.java#991-1008 Then, you'll need to create a patch to upload - see https://developer.mozilla.org/en-US/docs/Mercurial/Using_Mercurial#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F
Hi, I would like work on this bug.
Someone on IRC ("BlueCoolant") asked if he can work on this bug too. Is this you? Usually we assign bugs after the first patch has been uploaded. :)
I removed the broadcastPrefAction() method.
Attachment #8731551 - Flags: review?(s.kaspari)
Assignee: nobody → dpdineshp2
Status: NEW → ASSIGNED
looks like the definition of the following functions have been commented out and are unused. -> broadcastHealthReportUploadPref(final Context context, final boolean value) -> broadcastHealthReportUploadPref(final Context context) -> broadcastHealthReportPrune(final Context context) Can I remove these?
(In reply to vinayak from comment #4) > Can I remove these? Let's look at them separately. The code is commented out (we had to remove FHR) but the code calling them still exists.
Comment on attachment 8731551 [details] [diff] [review] bug1257217.patch Review of attachment 8731551 [details] [diff] [review]: ----------------------------------------------------------------- LGTM.
Attachment #8731551 - Flags: review?(s.kaspari) → review+
https://hg.mozilla.org/integration/fx-team/rev/7909460567c8f6c05c82d2675ddf6ee970ef1a21 Bug 1257217 - Remove unused method GeckoPreferences.broadcastPrefAction(). r=sebastian
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.