jit-tests creates file called 'null' in the current directory

RESOLVED FIXED in Firefox 48

Status

()

Core
JavaScript Engine
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jonco, Assigned: sfink)

Tracking

unspecified
mozilla48
Points:
---

Firefox Tracking Flags

(firefox48 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
As per summary, running the jit-tests suite creates a file in the current directory.  This should not happen.
(Reporter)

Comment 1

2 years ago
From jit-test/tests/basic/bug908915.js:

    // Suppress the large quantity of output on stdout (eg from calling
    // dumpHeap()).
    os.file.redirect(null);

I guess this doesn't work as expected.  Were you intending to make this throw away output in this case?
Flags: needinfo?(sphink)
(Assignee)

Comment 2

2 years ago
Oops! Yes, this is me. I just changed the interface of that function, and I thought the null usage was no longer needed with the new API. It wasn't very long ago that I did that redirect to null, either, so I should have remembered.

Thanks for tracking it down.
Assignee: nobody → sphink
Flags: needinfo?(sphink)
(Assignee)

Comment 3

2 years ago
Created attachment 8731357 [details] [diff] [review]
Fix os.file.redirect(null)
Attachment #8731357 - Flags: review?(jcoppeard)
(Reporter)

Updated

2 years ago
Attachment #8731357 - Flags: review?(jcoppeard) → review+

Comment 4

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/ac9d26a1c3f6

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ac9d26a1c3f6
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.