Closed Bug 1257223 Opened 4 years ago Closed 4 years ago

jit-tests creates file called 'null' in the current directory

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: jonco, Assigned: sfink)

Details

Attachments

(1 file)

As per summary, running the jit-tests suite creates a file in the current directory.  This should not happen.
From jit-test/tests/basic/bug908915.js:

    // Suppress the large quantity of output on stdout (eg from calling
    // dumpHeap()).
    os.file.redirect(null);

I guess this doesn't work as expected.  Were you intending to make this throw away output in this case?
Flags: needinfo?(sphink)
Oops! Yes, this is me. I just changed the interface of that function, and I thought the null usage was no longer needed with the new API. It wasn't very long ago that I did that redirect to null, either, so I should have remembered.

Thanks for tracking it down.
Assignee: nobody → sphink
Flags: needinfo?(sphink)
Attachment #8731357 - Flags: review?(jcoppeard)
Attachment #8731357 - Flags: review?(jcoppeard) → review+
https://hg.mozilla.org/mozilla-central/rev/ac9d26a1c3f6
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.