Closed Bug 1257229 Opened 8 years ago Closed 8 years ago

Adding additional reviewers re-requests review from reviewers already listed

Categories

(MozReview Graveyard :: Integration: Bugzilla, defect)

Product:
MozReview Graveyard
Component:
Integration: Bugzilla
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED DUPLICATE of bug 1273790

People

(Reporter: smacleod, Assigned: glob)

References

Details

STR:
 - Author pushes changes requesting review from UserA
 - Author publishes, causing r?UserA in bugzilla
 - UserA leaves a non ship-it review, clearing r? in bugzilla
 - Author adds UserB to the review request using the WebUI
 - Author publishes, causing r?UserB in bugzilla
 - r?UserA is also set in bugzilla

It appears we are setting the bugzilla attachment flags without any regard to who has already reviewed the change, even when no new diff is posted.

We probably aren't hitting this very much right now, but fixing this before Bug 1161230 lands will be important since I see us hitting it *much* more when we support reviewer delgation.
this should be much easier to fix once we track "fix it"s as r-.
Depends on: 1197879
Assignee: nobody → glob
Depends on: 1274371
i'll fix this as part of bug 1273790.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.