125723 - [FIX]'View: Message Source' should open in same window as 'View: Page Source'

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P3)

Description

[Jim Avera]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.8+) Gecko/20020206
BuildID:    

If an e-mail message source is viewed, a right mouse-click
brings up a menu with various options.  Some of the options
seem inappropriate, or are completely non-functional:

* View Page Source
     (probably inappropriate - the user is already viewing the source)
* Bookmark this page
     (definately inappropriate)
* Save Page As...
     (should work but is broken - nothing happens) 

Reproducible: Always
Steps to Reproduce:
1.View an e-mail message
2.View->Message Source (or Ctrl-U)
3.Put mouse in the message-source window and right-click
4.Select Save Page As... 

Actual Results:  Nothing happens

Expected Results:  Save dialog should appear for "Save Page As...".

Also, some of the other options are probably inappropriate
for viewing an e-mail message source and should not appear.

Comment 1

[Olga]

I can 'Save Page As' from Message Source context menu.
I cc: browser person to look at this.

Comment 2

[Olga]

There is bug 75338 for context menu issues on Browser. (Source View page is a
Browser page). If you consider that this one might be part of that meta bug,
mark as dup.

Comment 3

[jglick]

I would think it would it be appropriate to have a "View Message Source" open in 
the exact same window that the "View Page Source" does for the browser. So the 
context menu and available functionality would be the same for both.

Comment 4

[Olga]

Thanks, Jennifer. I change summary to reflect this: 'View: Message Source'(for a
message) should open in same window 'View: Page Source' (as browser page). Then,
the context menu for 'Message source' should be the same as the browser 'Page
Source' context menu.
Previous summary: 'Broken and inappropriate items in  right-click menu for
msg-source screen'.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Neil, all we'd need to do here is to make the view-source window not barf on the
content-type mail channels have, right?  And then just use it?

Comment 6

[[e-mail]]

bz, sounds good to me.

Comment 7

[Boris Zbarsky [:bzbarsky]]

*** Bug 153538 has been marked as a duplicate of this bug. ***

Comment 8

[Boris Zbarsky [:bzbarsky]]

Attachment: patch (untested; my mailnews is all confused at the moment)

Comment 9

[Boris Zbarsky [:bzbarsky]]

Tested that patch now.  Works as advertised on TV.

Comment 10

[[e-mail]]

Comment on attachment 97716 [details] [diff] [review]
patch (untested; my mailnews is all confused at the moment)

r=[e-mail]
Nice work, bz. Faster too!

Comment 11

[Boris Zbarsky [:bzbarsky]]

Attachment: same s/tab/spaces/, remove incorrect comment.

Comment 12

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 97932 [details] [diff] [review]
same s/tab/spaces/, remove incorrect comment.

carrying the r=neil

Comment 13

[jag (Peter Annema)]

Comment on attachment 97716 [details] [diff] [review]
patch (untested; my mailnews is all confused at the moment)

sr=jag

Comment 14

[Boris Zbarsky [:bzbarsky]]

mine.

Comment 15

[u32858]

Good stuff

Comment 16

[(not reading, please use [e-mail] instead)]

Comment on attachment 97932 [details] [diff] [review]
same s/tab/spaces/, remove incorrect comment.

sr=sspitzer

my only concern is what happens we finally break apart mail and browser?

I guess we'll have to figure that out when the time comes.  I'll add it to
http://www.mozilla.org/mailnews/minotaur/index.html

Comment 17

[[e-mail]]

> my only concern is what happens we finally break apart mail and browser?

Um, you are already using a *browser* window - this just uses a different one.

Comment 18

[Boris Zbarsky [:bzbarsky]]

fixed for 1.2b.

Comment 19

[[e-mail]]

Verified build 2002091204.

Comment 20

[[e-mail]]

*** Bug 126838 has been marked as a duplicate of this bug. ***