The default bug view has changed. See this FAQ.

[FlyWeb] Improve discovery frontend API

RESOLVED FIXED

Status

()

Core
Networking
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: djvj, Assigned: djvj)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [necko-active])

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

a year ago
The current discovery frontend API just exposes a |listServices| method, which assumes that discovery is always happening.  Provide API methods for frontend to start and stop discovery, and callbacks to inform the frontend of the changing list of services.
(Assignee)

Comment 1

a year ago
Created attachment 8731451 [details] [diff] [review]
improve-mdns-discovery-api.patch

Initial patch.  This cleans up the FlyWebMDNSService's discovery logic, and exposes a FlyWebDiscoveryManager API that allows for startDiscovery() and stopDiscovery() with a callback.

The startDiscovery() and stopDiscovery() webidl functions don't do anything yet.
(Assignee)

Comment 2

a year ago
Created attachment 8732374 [details] [diff] [review]
improve-mdns-discovery-api.patch

Ok this pretty much fixes up the discovery chrome API to work on a "id = startDiscovery(callback)", "stopDiscovery(id)" model, with active updates delivered via the callback.  The UI frontend is really responsive, and discovery shuts down when the UI is not open.

I did notice some weirdness with the Android frontend.  The frontend view's "show"/"hide" functions aren't invoked consistently in correspondence with navigating to the FlyWeb view and away from it.  That should be fixed, but that's just an interaction between the Java and browser.js code.  Will file a bug to fix it.
Attachment #8731451 - Attachment is obsolete: true
(Assignee)

Comment 3

a year ago
Created attachment 8732375 [details] [diff] [review]
improve-mdns-discovery-api.patch

Did not post the right patch.  This is the right one.
Attachment #8732374 - Attachment is obsolete: true
Kannan - you seem to be actively working on this; please change my whiteboard annotation to necko-backlog if not. Thanks.
Assignee: nobody → kvijayan
Whiteboard: [necko-active]
(Assignee)

Comment 5

a year ago
Landed: http://hg.mozilla.org/projects/larch/rev/115c2cabb870
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.