1257303 - accessible/windows/msaa/AccessibleWrap.cpp(1528): warning C4312: 'reinterpret_cast': conversion from 'const LONG' to 'void *' of greater size

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Gregory Szorc [:gps]]

This warning is about to be unmasked in bug 1124033 and it gets turned into an error when building with Visual Studio 2015 Update 1 in automation.

Comment 1

[Gregory Szorc [:gps]]

Attachment: MozReview Request: Bug 1257303 - Disable C4312 to unblock compilation on VS2015; r?tbsaude

As part of unblocking building with VS2015u1 in automation, I'm mass
disabling compiler warnings that are turned into errors. This is not
the preferred mechanism to fix compilation warnings. So hopefully
this patch never lands because someone insists on fixing the underlying
problem instead. But if it does land, hopefully the workaround is
only temporary.

Review commit: https://reviewboard.mozilla.org/r/40549/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/40549/

Comment 2

[Trevor Saunders (:tbsaunde)]

Comment on attachment 8731396 [details]
MozReview Request: Bug 1257303 - Disable C4312 to unblock compilation on VS2015; r?tbsaude

if I'm understanding the warning right its complaing about void* uniqueID = reinterpret_cast<void*>(<int variable>) which should be easily fixed by casting to uintptr_t before casting to void*.

Comment 3

[Gregory Szorc [:gps]]

Attachment: MozReview Request: Bug 1257303 - Cast to intptr_t to avoid C4312 on VS2015; r?tbsaunde

Without this, we get: C4312: 'reinterpret_cast': conversion from
'const LONG' to 'void *' of greater size

Review commit: https://reviewboard.mozilla.org/r/42111/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/42111/

Comment 4

[Gregory Szorc [:gps]]

Comment on attachment 8734147 [details]
MozReview Request: Bug 1257303 - Cast to intptr_t to avoid C4312 on VS2015; r?tbsaunde

tbsaunde reviewed over IRC.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ae01415f56b2

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ae01415f56b2