Closed Bug 1257305 Opened 4 years ago Closed 4 years ago

ipc\chromium\src\base/thread_local.h(110): warning C4312: 'reinterpret_cast': conversion from 'int' to 'void *' of greater size

Categories

(Core :: IPC, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: gps, Assigned: jld)

References

Details

Attachments

(1 file, 1 obsolete file)

This warning is being unmasked in bug 1124033. It gets turned into an error when run in automation with Visual Studio 2015 Update 1.
As part of unblocking building with VS2015u1 in automation, I'm mass
disabling compiler warnings that are turned into errors. This is not
the preferred mechanism to fix compilation warnings. So hopefully
this patch never lands because someone insists on fixing the underlying
problem instead. But if it does land, hopefully the workaround is
only temporary.

Review commit: https://reviewboard.mozilla.org/r/40553/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/40553/
Attachment #8731398 - Flags: review?(jwalden+bmo)
jld is a better reviewer for ipc/chromium code
Attachment #8731398 - Attachment description: MozReview Request: Bug 1257305 - Disable C4312 to unblock compilation on VS2015; r?Waldo → MozReview Request: Bug 1257305 - Disable C4312 to unblock compilation on VS2015; r?jld
Attachment #8731398 - Flags: review?(jwalden+bmo) → review?(jld)
Comment on attachment 8731398 [details]
MozReview Request: Bug 1257305 - Disable C4312 to unblock compilation on VS2015; r?jld

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40553/diff/1-2/
If it's just the one cast on ipc/chromium/src/base/thread_local.h line 110, then I'd rather just fix it.  Does this work?
Attachment #8731491 - Flags: review?(dvander)
Attachment #8731491 - Flags: feedback?(gps)
Comment on attachment 8731491 [details] [diff] [review]
bug1257305-intwarn-hg0.diff

Review of attachment 8731491 [details] [diff] [review]:
-----------------------------------------------------------------

I /think/ this makes the warning go away.
Attachment #8731491 - Flags: feedback?(gps) → feedback+
Attachment #8731491 - Flags: review?(dvander) → review+
Attachment #8731398 - Attachment is obsolete: true
Attachment #8731398 - Flags: review?(jld)
Assignee: nobody → jld
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/4cde1aabe95e
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.