Closed
Bug 1257305
Opened 8 years ago
Closed 8 years ago
ipc\chromium\src\base/thread_local.h(110): warning C4312: 'reinterpret_cast': conversion from 'int' to 'void *' of greater size
Categories
(Core :: IPC, defect)
Core
IPC
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: gps, Assigned: jld)
References
Details
Attachments
(1 file, 1 obsolete file)
754 bytes,
patch
|
dvander
:
review+
gps
:
feedback+
|
Details | Diff | Splinter Review |
This warning is being unmasked in bug 1124033. It gets turned into an error when run in automation with Visual Studio 2015 Update 1.
Reporter | ||
Comment 1•8 years ago
|
||
As part of unblocking building with VS2015u1 in automation, I'm mass disabling compiler warnings that are turned into errors. This is not the preferred mechanism to fix compilation warnings. So hopefully this patch never lands because someone insists on fixing the underlying problem instead. But if it does land, hopefully the workaround is only temporary. Review commit: https://reviewboard.mozilla.org/r/40553/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/40553/
Attachment #8731398 -
Flags: review?(jwalden+bmo)
Comment 2•8 years ago
|
||
jld is a better reviewer for ipc/chromium code
Reporter | ||
Updated•8 years ago
|
Attachment #8731398 -
Attachment description: MozReview Request: Bug 1257305 - Disable C4312 to unblock compilation on VS2015; r?Waldo → MozReview Request: Bug 1257305 - Disable C4312 to unblock compilation on VS2015; r?jld
Attachment #8731398 -
Flags: review?(jwalden+bmo) → review?(jld)
Reporter | ||
Comment 3•8 years ago
|
||
Comment on attachment 8731398 [details] MozReview Request: Bug 1257305 - Disable C4312 to unblock compilation on VS2015; r?jld Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40553/diff/1-2/
Assignee | ||
Comment 4•8 years ago
|
||
If it's just the one cast on ipc/chromium/src/base/thread_local.h line 110, then I'd rather just fix it. Does this work?
Attachment #8731491 -
Flags: review?(dvander)
Attachment #8731491 -
Flags: feedback?(gps)
Reporter | ||
Comment 5•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=cc3d32fb1d55 is testing attachment 8731491 [details] [diff] [review].
Reporter | ||
Comment 6•8 years ago
|
||
Comment on attachment 8731491 [details] [diff] [review] bug1257305-intwarn-hg0.diff Review of attachment 8731491 [details] [diff] [review]: ----------------------------------------------------------------- I /think/ this makes the warning go away.
Attachment #8731491 -
Flags: feedback?(gps) → feedback+
Reporter | ||
Comment 7•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6407f8aa9130
Attachment #8731491 -
Flags: review?(dvander) → review+
Assignee | ||
Updated•8 years ago
|
Attachment #8731398 -
Attachment is obsolete: true
Attachment #8731398 -
Flags: review?(jld)
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → jld
Keywords: checkin-needed
Comment 9•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4cde1aabe95e
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•