Closed Bug 1257323 Opened 8 years ago Closed 4 years ago

Unhack the C4577 warning disabling for warnings in ucasemap.h and uset.h

Categories

(Core :: JavaScript: Internationalization API, defect)

Product:
Core
Component:
JavaScript: Internationalization API
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED INVALID

People

(Reporter: gps, Unassigned)

References

Details

As part of bug 1124033 we added a bunch of CXXFLAGS += ['-wd5477'] throughout the tree to prevent warnings turned into errors when building with Visual Studio 2015.

The underlying warnings are all in 3rd party code:

intl\icu\source\common\unicode/ucasemap.h(93): warning C4577: 'noexcept' used with no exception handling mode specified; termination on exception is not guaranteed. Specify /EHsc
intl\icu\source\common\unicode/uset.h(322): warning C4577: 'noexcept' used with no exception handling mode specified; termination on exception is not guaranteed. Specify /EHsc

I see we have patches in tree we apply on top of ICU. Ideally we fix this upstream. But I suppose we could do a local fix.

At this time, every occurrence of "-wd5477" in tree are related to this ICU warning. So every occurrence should likely be removed as part of this bug.
Component: Internationalization → JavaScript: Internationalization API
Depends on: 1124033

No longer valid, because MSVC isn't a supported compiler anymore. And the C4577 workarounds have been removed at some point.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.