Open Bug 1257346 Opened 4 years ago Updated 2 years ago

dom/plugins/ipc/PluginInstanceChild.cpp(93): warning C4312: 'type cast': conversion from 'unsigned int' to 'HIMC' of greater size

Categories

(Core :: Plug-ins, defect, P3)

defect

Tracking

()

People

(Reporter: gps, Unassigned)

References

Details

(Keywords: good-first-bug)

Attachments

(1 file)

This warning is about to be unmasked in bug 1124033. It is turned into an error when building with Visual Studio 2015 Update 1 in automation.
As part of unblocking building with VS2015u1 in automation, I'm mass
disabling compiler warnings that are turned into errors. This is not
the preferred mechanism to fix compilation warnings. So hopefully
this patch never lands because someone insists on fixing the underlying
problem instead. But if it does land, hopefully the workaround is
only temporary.

Review commit: https://reviewboard.mozilla.org/r/40613/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/40613/
Attachment #8731460 - Flags: review?(aklotz)
Comment on attachment 8731460 [details]
MozReview Request: Bug 1257346 - Disable C4312 to unblock compilation on VS2015; r?aklotz

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40613/diff/1-2/
Attachment #8731460 - Flags: review?(aklotz) → review+
Comment on attachment 8731460 [details]
MozReview Request: Bug 1257346 - Disable C4312 to unblock compilation on VS2015; r?aklotz

https://reviewboard.mozilla.org/r/40613/#review37935
Backed out for Windows build bustage.

Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/272ec90eff71

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=f17a9b548316
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=24265176&repo=mozilla-inbound

12:24:53     INFO -  ==============================
12:24:53     INFO -  ERROR PROCESSING MOZBUILD FILE
12:24:53     INFO -  ==============================
12:24:53     INFO -  The error occurred while processing the following file:
12:24:53     INFO -      c:/builds/moz2_slave/m-in-w64-d-0000000000000000000/build/src/dom/plugins/ipc/moz.build
12:24:53     INFO -  The error was triggered on line 158 of this file:
12:24:53     INFO -      SOURCES['PluginScriptableObjectChild.cpp'].flags += ['-wd4312']
12:24:53     INFO -  An error was encountered as part of executing the file itself. The error appears to be the fault of the script.
12:24:53     INFO -  The error as reported by Python is:
12:24:53     INFO -      ['KeyError: u"\'PluginScriptableObjectChild.cpp\'"\n']
12:24:53     INFO -  Makefile:124: recipe for target 'backend.RecursiveMakeBackend' failed

Seems like PluginScriptableObjectChild.cpp needs to be added to https://dxr.mozilla.org/mozilla-central/source/dom/plugins/ipc/moz.build#97
Flags: needinfo?(gps)
Yeah, PluginScriptableObjectChild.cpp is in UNIFIED_SOURCES. Derp. The fix is to globally add -wd4312 for the entire directory. I'll do that and land.
Flags: needinfo?(gps)
I'm landing the -wd4312 in bug 1124033. Morphing this bug to track removing the disabling of the warning.
No longer blocks: 1124033
Depends on: 1124033
Mentor: benjamin
Keywords: good-first-bug
Priority: -- → P3
Mentor: benjamin
You need to log in before you can comment on or make changes to this bug.