Closed Bug 1257402 Opened 8 years ago Closed 8 years ago

Remove NS_NewPermanentAtom() and nsIAtomService.getPermanentAtom()

Categories

(Core :: XPCOM, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: n.nethercote, Assigned: n.nethercote)

References

Details

Attachments

(1 file)

The former is only used inconsequentially in tests. The second is not used at
all.
froydnj: please do a general review.

kmag: please review for the potential impact on add-ons of removing
nsIAtomService.getPermanentAtom(). I get zero hits for "getPermanentAtom" when
searching mxr.mozilla.org/addons, which I take to be a pretty good sign.
Attachment #8731513 - Flags: review?(nfroyd)
Attachment #8731513 - Flags: review?(kmaglione+bmo)
Depends on: 1257128
Comment on attachment 8731513 [details] [diff] [review]
Remove NS_NewPermanentAtom() and nsIAtomService.getPermanentAtom()

Review of attachment 8731513 [details] [diff] [review]:
-----------------------------------------------------------------

I don't think this is likely to affect add-ons. I can't find any add-on code that uses it or examples that reference it, and there shouldn't be any indirect effects.

There may be some binaries or plugins that are affected, but they'd have to be doing something we don't support.
Attachment #8731513 - Flags: review?(kmaglione+bmo) → review+
Attachment #8731513 - Flags: review?(nfroyd) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/80beb85ac554595b38a13825d35c680a06eb0656
Bug 1257402 - Remove NS_NewPermanentAtom() and nsIAtomService.getPermanentAtom(). r=froydnj,kmag.
https://hg.mozilla.org/mozilla-central/rev/80beb85ac554
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.