Closed Bug 1257415 Opened 4 years ago Closed 4 years ago

Move --with-l10n-base to moz.configure

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox48 fixed)

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
Comment on attachment 8731539 [details]
MozReview Request: Bug 1257415 - Move --with-l10n-base to moz.configure

https://reviewboard.mozilla.org/r/40689/#review37219

::: toolkit/moz.configure:21
(Diff revision 1)
> +    if value:
> +        path = value[0]
> +        if not os.path.isdir(path):
> +            error("Invalid value --with-l10n-base, %s doesn't exist" % path)
> +
> +        set_config('L10NBASEDIR', os.path.realpath(os.path.abspath(path)))

Want to take bets on this breaking something due to something in non-Windows land not expecting an absolute path?

I have no reason to believe this. I just have no faith in anything l10n related when it comes to automation.
Attachment #8731539 - Flags: review?(gps) → review+
https://reviewboard.mozilla.org/r/40689/#review37219

> Want to take bets on this breaking something due to something in non-Windows land not expecting an absolute path?
> 
> I have no reason to believe this. I just have no faith in anything l10n related when it comes to automation.

In fact, the cd foo && pwd pattern from old-configure *does* make it an absolute path already. pwd -P removes symlinks, which is equivalent to os.path.realpath, and pwd -W prints a Windows path as opposed to a msys path, which is all good.

Where this might fail, though, is with automation passing insane number of backslashes. I told them to use forward slashes already.
https://reviewboard.mozilla.org/r/40689/#review37219

> In fact, the cd foo && pwd pattern from old-configure *does* make it an absolute path already. pwd -P removes symlinks, which is equivalent to os.path.realpath, and pwd -W prints a Windows path as opposed to a msys path, which is all good.
> 
> Where this might fail, though, is with automation passing insane number of backslashes. I told them to use forward slashes already.

What I was comment on what that `cd $L10NBASEDIR && pwd -W` only occurs on Windows before. Now it occurs everywhere. I hope that doesn't matter.
(In reply to Gregory Szorc [:gps] from comment #4)
> https://reviewboard.mozilla.org/r/40689/#review37219
> 
> > In fact, the cd foo && pwd pattern from old-configure *does* make it an absolute path already. pwd -P removes symlinks, which is equivalent to os.path.realpath, and pwd -W prints a Windows path as opposed to a msys path, which is all good.
> > 
> > Where this might fail, though, is with automation passing insane number of backslashes. I told them to use forward slashes already.
> 
> What I was comment on what that `cd $L10NBASEDIR && pwd -W` only occurs on
> Windows before. Now it occurs everywhere. I hope that doesn't matter.

on other platforms, there was `cd $L10NBASEDIR && pwd -P`. That was my point.
https://hg.mozilla.org/mozilla-central/rev/818165fa787b
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Flags: needinfo?(mh+mozilla)
https://hg.mozilla.org/mozilla-central/rev/f80d947bc41e
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.