Closed
Bug 1257415
Opened 8 years ago
Closed 8 years ago
Move --with-l10n-base to moz.configure
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox48 fixed)
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
No description provided.
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/40689/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/40689/
Attachment #8731539 -
Flags: review?(gps)
Comment 2•8 years ago
|
||
Comment on attachment 8731539 [details] MozReview Request: Bug 1257415 - Move --with-l10n-base to moz.configure https://reviewboard.mozilla.org/r/40689/#review37219 ::: toolkit/moz.configure:21 (Diff revision 1) > + if value: > + path = value[0] > + if not os.path.isdir(path): > + error("Invalid value --with-l10n-base, %s doesn't exist" % path) > + > + set_config('L10NBASEDIR', os.path.realpath(os.path.abspath(path))) Want to take bets on this breaking something due to something in non-Windows land not expecting an absolute path? I have no reason to believe this. I just have no faith in anything l10n related when it comes to automation.
Attachment #8731539 -
Flags: review?(gps) → review+
Assignee | ||
Comment 3•8 years ago
|
||
https://reviewboard.mozilla.org/r/40689/#review37219 > Want to take bets on this breaking something due to something in non-Windows land not expecting an absolute path? > > I have no reason to believe this. I just have no faith in anything l10n related when it comes to automation. In fact, the cd foo && pwd pattern from old-configure *does* make it an absolute path already. pwd -P removes symlinks, which is equivalent to os.path.realpath, and pwd -W prints a Windows path as opposed to a msys path, which is all good. Where this might fail, though, is with automation passing insane number of backslashes. I told them to use forward slashes already.
Comment 4•8 years ago
|
||
https://reviewboard.mozilla.org/r/40689/#review37219 > In fact, the cd foo && pwd pattern from old-configure *does* make it an absolute path already. pwd -P removes symlinks, which is equivalent to os.path.realpath, and pwd -W prints a Windows path as opposed to a msys path, which is all good. > > Where this might fail, though, is with automation passing insane number of backslashes. I told them to use forward slashes already. What I was comment on what that `cd $L10NBASEDIR && pwd -W` only occurs on Windows before. Now it occurs everywhere. I hope that doesn't matter.
Assignee | ||
Comment 5•8 years ago
|
||
(In reply to Gregory Szorc [:gps] from comment #4) > https://reviewboard.mozilla.org/r/40689/#review37219 > > > In fact, the cd foo && pwd pattern from old-configure *does* make it an absolute path already. pwd -P removes symlinks, which is equivalent to os.path.realpath, and pwd -W prints a Windows path as opposed to a msys path, which is all good. > > > > Where this might fail, though, is with automation passing insane number of backslashes. I told them to use forward slashes already. > > What I was comment on what that `cd $L10NBASEDIR && pwd -W` only occurs on > Windows before. Now it occurs everywhere. I hope that doesn't matter. on other platforms, there was `cd $L10NBASEDIR && pwd -P`. That was my point.
Comment 7•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/818165fa787b
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Comment 8•8 years ago
|
||
backed this out in https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=3e04659fdf6a since this might have broken the l10n nightly's like https://treeherder.mozilla.org/logviewer.html#?job_id=3502846&repo=mozilla-central
Flags: needinfo?(mh+mozilla)
Updated•8 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Updated•8 years ago
|
Flags: needinfo?(mh+mozilla)
Comment 10•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f80d947bc41e
Status: REOPENED → RESOLVED
Closed: 8 years ago → 8 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•