Closed
Bug 1257416
Opened 8 years ago
Closed 8 years ago
Move MOZTTDIR to moz.configure
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox48 fixed)
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file)
No description provided.
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/40693/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/40693/
Attachment #8731543 -
Flags: review?(gps)
Comment 2•8 years ago
|
||
Comment on attachment 8731543 [details] MozReview Request: Bug 1257416 - Move MOZTTDIR to moz.configure https://reviewboard.mozilla.org/r/40693/#review37223
Attachment #8731543 -
Flags: review?(gps) → review+
Comment 4•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8e9ad372486b
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Comment 5•8 years ago
|
||
sorry had to back this out because of https://bugzilla.mozilla.org/show_bug.cgi?id=1257415 and this was one of the dependency's for old-configure.in for the backout
Status: RESOLVED → REOPENED
Flags: needinfo?(mh+mozilla)
Resolution: FIXED → ---
Assignee | ||
Comment 7•8 years ago
|
||
(In reply to Carsten Book [:Tomcat] from comment #5) > sorry had to back this out because of > https://bugzilla.mozilla.org/show_bug.cgi?id=1257415 and this was one of the > dependency's for old-configure.in for the backout I don't know how you came to this conclusion, the patch from bug 1257415 was trivially backoutable without backing out anything else.
Flags: needinfo?(mh+mozilla) → needinfo?(cbook)
Comment 9•8 years ago
|
||
(In reply to Mike Hommey [:glandium] from comment #7) > (In reply to Carsten Book [:Tomcat] from comment #5) > > sorry had to back this out because of > > https://bugzilla.mozilla.org/show_bug.cgi?id=1257415 and this was one of the > > dependency's for old-configure.in for the backout > > I don't know how you came to this conclusion, the patch from bug 1257415 was > trivially backoutable without backing out anything else. patching file old-configure.in Hunk #1 FAILED at 95 1 out of 2 hunks FAILED -- saving rejects to file old-configure.in.rej abort: patch failed to apply was what i got trying to backout bug 1257415 alone
Flags: needinfo?(cbook)
Assignee | ||
Comment 10•8 years ago
|
||
You should have looked at old-configure.in.rej and see how trivial it was to apply by hand. It might even have applied with -F5 or more
Comment 11•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f47b283d4aac
Status: REOPENED → RESOLVED
Closed: 8 years ago → 8 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•