Move MOZTTDIR to moz.configure

RESOLVED FIXED in Firefox 48

Status

Firefox Build System
General
RESOLVED FIXED
2 years ago
4 months ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

unspecified
mozilla48

Firefox Tracking Flags

(firefox48 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Updated

2 years ago
Depends on: 1257385
(Assignee)

Updated

2 years ago
No longer depends on: 1257385
(Assignee)

Comment 1

2 years ago
Created attachment 8731543 [details]
MozReview Request: Bug 1257416 - Move MOZTTDIR to moz.configure

Review commit: https://reviewboard.mozilla.org/r/40693/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/40693/
Attachment #8731543 - Flags: review?(gps)

Comment 2

2 years ago
Comment on attachment 8731543 [details]
MozReview Request: Bug 1257416 - Move MOZTTDIR to moz.configure

https://reviewboard.mozilla.org/r/40693/#review37223
Attachment #8731543 - Flags: review?(gps) → review+

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/8e9ad372486b
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
sorry had to back this out because of https://bugzilla.mozilla.org/show_bug.cgi?id=1257415 and this was one of the dependency's for old-configure.in for the backout
Status: RESOLVED → REOPENED
Flags: needinfo?(mh+mozilla)
Resolution: FIXED → ---
(Assignee)

Comment 7

2 years ago
(In reply to Carsten Book [:Tomcat] from comment #5)
> sorry had to back this out because of
> https://bugzilla.mozilla.org/show_bug.cgi?id=1257415 and this was one of the
> dependency's for old-configure.in for the backout

I don't know how you came to this conclusion, the patch from bug 1257415 was trivially backoutable without backing out anything else.
Flags: needinfo?(mh+mozilla) → needinfo?(cbook)
(In reply to Mike Hommey [:glandium] from comment #7)
> (In reply to Carsten Book [:Tomcat] from comment #5)
> > sorry had to back this out because of
> > https://bugzilla.mozilla.org/show_bug.cgi?id=1257415 and this was one of the
> > dependency's for old-configure.in for the backout
> 
> I don't know how you came to this conclusion, the patch from bug 1257415 was
> trivially backoutable without backing out anything else.

patching file old-configure.in
Hunk #1 FAILED at 95
1 out of 2 hunks FAILED -- saving rejects to file old-configure.in.rej
abort: patch failed to apply

was what i got trying to backout bug 1257415 alone
Flags: needinfo?(cbook)
(Assignee)

Comment 10

2 years ago
You should have looked at old-configure.in.rej and see how trivial it was to apply by hand. It might even have applied with -F5 or more

Comment 11

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f47b283d4aac
Status: REOPENED → RESOLVED
Last Resolved: 2 years ago2 years ago
Resolution: --- → FIXED
Depends on: 1258294

Updated

4 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.