1257441 - Remove arm detection for MSVC

Status: RESOLVED FIXED

(Core :: mozglue, defect)

Description

[Makoto Kato [:m_kato]]

arm.h still have CPU feature detection by Windows MSVC compiler.  This code is WinCE-era.  So it is unnecessary.

If we need current win32/arm such as WinRT/Win10 mobile, this is also unnecessary.  Its architecture requires THUMB2+NEON.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: MozReview Request: Bug 1257441 - Remove arm detection for WinCE using MSVS. r?glandium

arm.h still have CPU feature detection for Microsoft Compiler that is used by WinCE.   Since we don't have the target for WinCE, we should remove it.

Also, even if you need it for Win32/arm that is Windows Mobile and Windows IOT in feature, this is unnecessary.  Win32/arm ABI requires thumb2+NEON at least.

Review commit: https://reviewboard.mozilla.org/r/51319/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/51319/

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 8750177 [details]
MozReview Request: Bug 1257441 - Remove arm detection for WinCE using MSVS. r?glandium

https://reviewboard.mozilla.org/r/51319/#review48617

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/92ba89f2d72e

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/92ba89f2d72e