Closed Bug 1257445 Opened 4 years ago Closed 4 years ago

Move some platform-specific defines to moz.configure

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox48 fixed)

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

No description provided.
Blocks: pyconfigure
Attachment #8731933 - Flags: review?(gps) → review+
Comment on attachment 8731933 [details]
MozReview Request: Bug 1257445 - Move some platform-specific defines to moz.configure. r=gps

https://reviewboard.mozilla.org/r/40943/#review37485

Looks like a straight conversion to me.
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/7f3a38541755

Here is the funny thing: XP_LINUX was not set in js/src, but it was used. So now that we set it, we hit the fact that the code behind #ifdef XP_LINUX doesn't actually build on Android.
Comment on attachment 8731933 [details]
MozReview Request: Bug 1257445 - Move some platform-specific defines to moz.configure. r=gps

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40943/diff/1-2/
Attachment #8731933 - Attachment description: MozReview Request: Bug 1257445 - Move some platform-specific defines to moz.configure → MozReview Request: Bug 1257445 - Move some platform-specific defines to moz.configure. r=gps
P_LINUX means the kernel is Linux, which can mean glibc, bionic
(Android), etc. Only the former supports sched_getcpu.

"Fortunately", XP_LINUX was never set for js/src, so this wasn't a
problem... until we do set it, which we do in this bug.

Review commit: https://reviewboard.mozilla.org/r/41595/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/41595/
Attachment #8733144 - Flags: review?(jimb)
Comment on attachment 8733144 [details]
MozReview Request: Bug 1257445 - #ifdef on __GLIBC__ for sched_getcpu, which is a glibc feature

https://reviewboard.mozilla.org/r/41595/#review38019

Looks good to me.
Attachment #8733144 - Flags: review?(jimb) → review+
Blocks: 1258590
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.