Closed
Bug 1257445
Opened 8 years ago
Closed 8 years ago
Move some platform-specific defines to moz.configure
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox48 fixed)
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
No description provided.
Assignee | ||
Updated•8 years ago
|
Blocks: pyconfigure
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/40943/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/40943/
Attachment #8731933 -
Flags: review?(gps)
Updated•8 years ago
|
Attachment #8731933 -
Flags: review?(gps) → review+
Comment 2•8 years ago
|
||
Comment on attachment 8731933 [details] MozReview Request: Bug 1257445 - Move some platform-specific defines to moz.configure. r=gps https://reviewboard.mozilla.org/r/40943/#review37485 Looks like a straight conversion to me.
Assignee | ||
Comment 4•8 years ago
|
||
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/7f3a38541755 Here is the funny thing: XP_LINUX was not set in js/src, but it was used. So now that we set it, we hit the fact that the code behind #ifdef XP_LINUX doesn't actually build on Android.
Assignee | ||
Comment 5•8 years ago
|
||
Comment on attachment 8731933 [details] MozReview Request: Bug 1257445 - Move some platform-specific defines to moz.configure. r=gps Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40943/diff/1-2/
Attachment #8731933 -
Attachment description: MozReview Request: Bug 1257445 - Move some platform-specific defines to moz.configure → MozReview Request: Bug 1257445 - Move some platform-specific defines to moz.configure. r=gps
Assignee | ||
Comment 6•8 years ago
|
||
P_LINUX means the kernel is Linux, which can mean glibc, bionic (Android), etc. Only the former supports sched_getcpu. "Fortunately", XP_LINUX was never set for js/src, so this wasn't a problem... until we do set it, which we do in this bug. Review commit: https://reviewboard.mozilla.org/r/41595/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/41595/
Attachment #8733144 -
Flags: review?(jimb)
Comment 7•8 years ago
|
||
Comment on attachment 8733144 [details] MozReview Request: Bug 1257445 - #ifdef on __GLIBC__ for sched_getcpu, which is a glibc feature https://reviewboard.mozilla.org/r/41595/#review38019 Looks good to me.
Attachment #8733144 -
Flags: review?(jimb) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/5540673db52d https://hg.mozilla.org/integration/mozilla-inbound/rev/a5494b3c4fad
Comment 10•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5540673db52d https://hg.mozilla.org/mozilla-central/rev/a5494b3c4fad https://hg.mozilla.org/mozilla-central/rev/6ffdefc8cba7
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•