Closed Bug 1257468 Opened 4 years ago Closed 4 years ago

Move JS_STANDALONE to moz.configure

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox48 fixed)

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

No description provided.
This has the side effect of making the variable available in js/src,
which it was not in the past.

Review commit: https://reviewboard.mozilla.org/r/40985/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/40985/
Attachment #8732095 - Flags: review?(ted)
Now that MOZ_BUILD_APP is set to js when building js/src, we can
distinguish those builds with MOZ_BUILD_APP==js instead of BUILDING_JS.
Consequently, remove BUILDING_JS.

Review commit: https://reviewboard.mozilla.org/r/40987/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/40987/
Attachment #8732096 - Flags: review?(ted)
https://reviewboard.mozilla.org/r/40989/#review37597

::: js/moz.configure:24
(Diff revision 1)
> +       help='Reserved for internal use')
> +
> +@depends('JS_STANDALONE')
> +def js_standalone(value):
> +    if value:
> +        set_config('JS_STANDALONE', '1')

Note this doesn't add a set_define because the AC_DEFINE was not used.
Comment on attachment 8732095 [details]
MozReview Request: Bug 1257468 - Move setting MOZ_BUILD_APP subst and define to moz.configure

https://reviewboard.mozilla.org/r/40985/#review37981

After some discussion in #build re: AC_DEFINE vs. AC_DEFINE_UNQUOTED, this seems correct to me.
Attachment #8732095 - Flags: review+
Comment on attachment 8732096 [details]
MozReview Request: Bug 1257468 - Replace tests on BUILDING_JS with tests on MOZ_BUILD_APP==js

https://reviewboard.mozilla.org/r/40987/#review37983

Mechanical patch looks fine.
Attachment #8732096 - Flags: review+
Attachment #8732095 - Flags: review?(ted)
Attachment #8732096 - Flags: review?(ted)
Attachment #8732097 - Flags: review?(ted)
Version: unspecified → Trunk
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.