Closed
Bug 1257468
Opened 8 years ago
Closed 8 years ago
Move JS_STANDALONE to moz.configure
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox48 fixed)
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
No description provided.
Assignee | ||
Comment 1•8 years ago
|
||
This has the side effect of making the variable available in js/src, which it was not in the past. Review commit: https://reviewboard.mozilla.org/r/40985/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/40985/
Attachment #8732095 -
Flags: review?(ted)
Assignee | ||
Comment 2•8 years ago
|
||
Now that MOZ_BUILD_APP is set to js when building js/src, we can distinguish those builds with MOZ_BUILD_APP==js instead of BUILDING_JS. Consequently, remove BUILDING_JS. Review commit: https://reviewboard.mozilla.org/r/40987/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/40987/
Attachment #8732096 -
Flags: review?(ted)
Assignee | ||
Comment 3•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/40989/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/40989/
Attachment #8732097 -
Flags: review?(ted)
Assignee | ||
Comment 4•8 years ago
|
||
https://reviewboard.mozilla.org/r/40989/#review37597 ::: js/moz.configure:24 (Diff revision 1) > + help='Reserved for internal use') > + > +@depends('JS_STANDALONE') > +def js_standalone(value): > + if value: > + set_config('JS_STANDALONE', '1') Note this doesn't add a set_define because the AC_DEFINE was not used.
Comment 5•8 years ago
|
||
Comment on attachment 8732095 [details] MozReview Request: Bug 1257468 - Move setting MOZ_BUILD_APP subst and define to moz.configure https://reviewboard.mozilla.org/r/40985/#review37981 After some discussion in #build re: AC_DEFINE vs. AC_DEFINE_UNQUOTED, this seems correct to me.
Attachment #8732095 -
Flags: review+
Comment 6•8 years ago
|
||
Comment on attachment 8732096 [details] MozReview Request: Bug 1257468 - Replace tests on BUILDING_JS with tests on MOZ_BUILD_APP==js https://reviewboard.mozilla.org/r/40987/#review37983 Mechanical patch looks fine.
Attachment #8732096 -
Flags: review+
Comment 7•8 years ago
|
||
Comment on attachment 8732097 [details] MozReview Request: Bug 1257468 - Move JS_STANDALONE to moz.configure https://reviewboard.mozilla.org/r/40989/#review37985 lgtm.
Attachment #8732097 -
Flags: review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/a63437a74f7a https://hg.mozilla.org/integration/mozilla-inbound/rev/48a94777837d https://hg.mozilla.org/integration/mozilla-inbound/rev/f5090987b7c6
Assignee | ||
Updated•8 years ago
|
Attachment #8732095 -
Flags: review?(ted)
Assignee | ||
Updated•8 years ago
|
Attachment #8732096 -
Flags: review?(ted)
Assignee | ||
Updated•8 years ago
|
Attachment #8732097 -
Flags: review?(ted)
Comment 10•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/8823b620ef0f https://hg.mozilla.org/integration/mozilla-inbound/rev/528c71c035b4 https://hg.mozilla.org/integration/mozilla-inbound/rev/71ed98e78d37 https://hg.mozilla.org/integration/mozilla-inbound/rev/2f1e15a63791
Comment 11•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8823b620ef0f https://hg.mozilla.org/mozilla-central/rev/528c71c035b4 https://hg.mozilla.org/mozilla-central/rev/71ed98e78d37 https://hg.mozilla.org/mozilla-central/rev/2f1e15a63791
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Updated•8 years ago
|
Version: unspecified → Trunk
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•