Closed Bug 1257488 Opened 4 years ago Closed 4 years ago

Fix test_offline_gzip.html to work on e10s

Categories

(Core :: Networking: Cache, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
e10s + ---
firefox48 --- fixed

People

(Reporter: gsvelto, Assigned: gsvelto)

References

(Blocks 1 open bug)

Details

(Whiteboard: [necko-active])

Attachments

(1 file)

As per title.
This is my first attempt at fixing/rewriting a mochitest so I might have gotten some things wrong. It seems to work fine on both regular and e10s modes though so hopefully it's not too bad :)
Attachment #8731672 - Flags: review?(honzab.moz)
Can you please describe more in detail what the patch exactly does and change?  Will help with review.
Flags: needinfo?(gsvelto)
Whiteboard: [necko-active]
(In reply to Honza Bambas (:mayhemer) from comment #2)
> Can you please describe more in detail what the patch exactly does and
> change?  Will help with review.

Right, sorry about that. So the original test used the SpecialPowers API to grab hold of the browser window and allow the test to store local data by clicking on the appropriate button and by setting the offline-apps.allow_by_default preference. None of this action are allowed in e10s mode (IIRC they would happen in the content process while they need to happen in the parent one) and neither is the permission management done in the cleanup procedure. So I've modified the test to be a mochitest-browser test and split the operations appropriately between the parent and the content processes. Note that I've removed the part where we click the "Allow" dialog button because setting the offline-apps.allow_by_default pref makes it redundant.
Flags: needinfo?(gsvelto)
Comment on attachment 8731672 [details] [diff] [review]
[PATCH] Fix test_gzip_offline.html to work with e10s enabled

Review of attachment 8731672 [details] [diff] [review]:
-----------------------------------------------------------------

My r+ depends on a green try run (I don't see any in the bug..)
Attachment #8731672 - Flags: review?(honzab.moz) → review+
I just backed out my patch for bug 621158 because of this test, so if they land together they will likely work. I can do a trypush tomorrow if nobody has beaten me to it. :-)
Blocks: 621158
Thanks Honza, the try run is here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=76890c0b8394

I'll land as soon as it turns green.
https://hg.mozilla.org/mozilla-central/rev/116497ecbdab
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.