1257526 - Return unsupported operation error for screen orientation commands on desktop

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Andreas Tolfsen ❲:ato❳]

The setScreenOrientation and getScreenOrientation methods on GeckoDriver should throw UnsupportedOperationError on desktop.

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: MozReview Request: Bug 1257526 - Return unsupported operation error for screen orientation on desktop; r=automatedtester

Review commit: https://reviewboard.mozilla.org/r/40785/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/40785/

Comment 2

[Andreas Tolfsen ❲:ato❳]

Attachment: MozReview Request: Bug 1257526 - Harmonise unsupported operation error usage; r=automatedtester

Throw unsupported operation errors the same way throughout Marionette.

Review commit: https://reviewboard.mozilla.org/r/40787/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/40787/

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Sweet. This will fix at least a part of bug 1256682.

Comment 4

[David Burns :automatedtester]

Comment on attachment 8731710 [details]
MozReview Request: Bug 1257526 - Return unsupported operation error for screen orientation on desktop; r=automatedtester

https://reviewboard.mozilla.org/r/40785/#review37407

::: testing/marionette/harness/marionette/tests/unit/test_screen_orientation.py:15
(Diff revision 1)
>  unknown_orientation = "Unknown screen orientation: %s"
>  
>  class TestScreenOrientation(MarionetteTestCase):
> +    def setUp(self):
> +        MarionetteTestCase.setUp(self)
> +        self.is_mobile = self.marionette.session_capabilities["platformName"] == "B2G"

Can you change this to ` != "Firefox"`

Comment 5

[David Burns :automatedtester]

Comment on attachment 8731711 [details]
MozReview Request: Bug 1257526 - Harmonise unsupported operation error usage; r=automatedtester

https://reviewboard.mozilla.org/r/40787/#review37435

Comment 6

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8731710 [details]
MozReview Request: Bug 1257526 - Return unsupported operation error for screen orientation on desktop; r=automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40785/diff/1-2/

Comment 7

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8731711 [details]
MozReview Request: Bug 1257526 - Harmonise unsupported operation error usage; r=automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40787/diff/1-2/

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f8c07a51e7ce
https://hg.mozilla.org/integration/mozilla-inbound/rev/c1fb88d419ca

Comment 9

[Carsten Book [:Tomcat]]

backed out for test failures like https://treeherder.mozilla.org/logviewer.html#?job_id=24325568&repo=mozilla-inbound

Comment 10

[Pulsebot]

Backout:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4711cd73ee95
https://hg.mozilla.org/integration/mozilla-inbound/rev/d087c2f9a1ca

Comment 11

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8731710 [details]
MozReview Request: Bug 1257526 - Return unsupported operation error for screen orientation on desktop; r=automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40785/diff/2-3/

Comment 12

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8731711 [details]
MozReview Request: Bug 1257526 - Harmonise unsupported operation error usage; r=automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40787/diff/2-3/

Comment 13

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/66fd82b72d1e
https://hg.mozilla.org/integration/mozilla-inbound/rev/0d344473d50f

Comment 14

[Andreas Tolfsen ❲:ato❳]

(In reply to Carsten Book [:Tomcat] from comment #9)
> backed out for test failures like
> https://treeherder.mozilla.org/logviewer.html#?job_id=24325568&repo=mozilla-
> inbound

Sorry, my mistake.  Issue was caused by a fixup to the patch.

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/66fd82b72d1e
https://hg.mozilla.org/mozilla-central/rev/0d344473d50f

Comment 16

[David Burns :automatedtester]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c6a28b230c74
https://hg.mozilla.org/releases/mozilla-aurora/rev/89dadb7edac9