Return unsupported operation error for screen orientation commands on desktop

RESOLVED FIXED in Firefox 47

Status

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: ato, Assigned: ato)

Tracking

({pi-marionette-server})

Version 3
mozilla48
Points:
---

Firefox Tracking Flags

(firefox47 fixed, firefox48 fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

3 years ago
The setScreenOrientation and getScreenOrientation methods on GeckoDriver should throw UnsupportedOperationError on desktop.
(Assignee)

Updated

3 years ago
Assignee: nobody → ato
Status: NEW → ASSIGNED
(Assignee)

Comment 2

3 years ago
Throw unsupported operation errors the same way throughout Marionette.

Review commit: https://reviewboard.mozilla.org/r/40787/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/40787/
Attachment #8731711 - Flags: review?(dburns)
Sweet. This will fix at least a part of bug 1256682.
Blocks: 1256682
Comment on attachment 8731710 [details]
MozReview Request: Bug 1257526 - Return unsupported operation error for screen orientation on desktop; r=automatedtester

https://reviewboard.mozilla.org/r/40785/#review37407

::: testing/marionette/harness/marionette/tests/unit/test_screen_orientation.py:15
(Diff revision 1)
>  unknown_orientation = "Unknown screen orientation: %s"
>  
>  class TestScreenOrientation(MarionetteTestCase):
> +    def setUp(self):
> +        MarionetteTestCase.setUp(self)
> +        self.is_mobile = self.marionette.session_capabilities["platformName"] == "B2G"

Can you change this to ` != "Firefox"`
Attachment #8731710 - Flags: review?(dburns) → review+
Attachment #8731711 - Flags: review?(dburns) → review+
Comment on attachment 8731711 [details]
MozReview Request: Bug 1257526 - Harmonise unsupported operation error usage; r=automatedtester

https://reviewboard.mozilla.org/r/40787/#review37435
(Assignee)

Comment 6

3 years ago
Comment on attachment 8731710 [details]
MozReview Request: Bug 1257526 - Return unsupported operation error for screen orientation on desktop; r=automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40785/diff/1-2/
(Assignee)

Comment 7

3 years ago
Comment on attachment 8731711 [details]
MozReview Request: Bug 1257526 - Harmonise unsupported operation error usage; r=automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40787/diff/1-2/
(Assignee)

Comment 11

3 years ago
Comment on attachment 8731710 [details]
MozReview Request: Bug 1257526 - Return unsupported operation error for screen orientation on desktop; r=automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40785/diff/2-3/
Attachment #8731710 - Attachment description: MozReview Request: Bug 1257526 - Return unsupported operation error for screen orientation on desktop; r?automatedtester → MozReview Request: Bug 1257526 - Return unsupported operation error for screen orientation on desktop; r=automatedtester
(Assignee)

Comment 12

3 years ago
Comment on attachment 8731711 [details]
MozReview Request: Bug 1257526 - Harmonise unsupported operation error usage; r=automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40787/diff/2-3/
Attachment #8731711 - Attachment description: MozReview Request: Bug 1257526 - Harmonise unsupported operation error usage; r?automatedtester → MozReview Request: Bug 1257526 - Harmonise unsupported operation error usage; r=automatedtester
(Assignee)

Comment 14

3 years ago
(In reply to Carsten Book [:Tomcat] from comment #9)
> backed out for test failures like
> https://treeherder.mozilla.org/logviewer.html#?job_id=24325568&repo=mozilla-
> inbound

Sorry, my mistake.  Issue was caused by a fixup to the patch.
Flags: needinfo?(ato)

Comment 15

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/66fd82b72d1e
https://hg.mozilla.org/mozilla-central/rev/0d344473d50f
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.