Closed
Bug 1257526
Opened 8 years ago
Closed 8 years ago
Return unsupported operation error for screen orientation commands on desktop
Categories
(Remote Protocol :: Marionette, defect)
Tracking
(firefox47 fixed, firefox48 fixed)
RESOLVED
FIXED
mozilla48
People
(Reporter: ato, Assigned: ato)
References
Details
(Keywords: pi-marionette-server)
Attachments
(2 files)
The setScreenOrientation and getScreenOrientation methods on GeckoDriver should throw UnsupportedOperationError on desktop.
Assignee | ||
Updated•8 years ago
|
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/40785/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/40785/
Attachment #8731710 -
Flags: review?(dburns)
Assignee | ||
Comment 2•8 years ago
|
||
Throw unsupported operation errors the same way throughout Marionette. Review commit: https://reviewboard.mozilla.org/r/40787/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/40787/
Attachment #8731711 -
Flags: review?(dburns)
Comment 4•8 years ago
|
||
Comment on attachment 8731710 [details] MozReview Request: Bug 1257526 - Return unsupported operation error for screen orientation on desktop; r=automatedtester https://reviewboard.mozilla.org/r/40785/#review37407 ::: testing/marionette/harness/marionette/tests/unit/test_screen_orientation.py:15 (Diff revision 1) > unknown_orientation = "Unknown screen orientation: %s" > > class TestScreenOrientation(MarionetteTestCase): > + def setUp(self): > + MarionetteTestCase.setUp(self) > + self.is_mobile = self.marionette.session_capabilities["platformName"] == "B2G" Can you change this to ` != "Firefox"`
Attachment #8731710 -
Flags: review?(dburns) → review+
Updated•8 years ago
|
Attachment #8731711 -
Flags: review?(dburns) → review+
Comment 5•8 years ago
|
||
Comment on attachment 8731711 [details] MozReview Request: Bug 1257526 - Harmonise unsupported operation error usage; r=automatedtester https://reviewboard.mozilla.org/r/40787/#review37435
Assignee | ||
Comment 6•8 years ago
|
||
Comment on attachment 8731710 [details] MozReview Request: Bug 1257526 - Return unsupported operation error for screen orientation on desktop; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40785/diff/1-2/
Assignee | ||
Comment 7•8 years ago
|
||
Comment on attachment 8731711 [details] MozReview Request: Bug 1257526 - Harmonise unsupported operation error usage; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40787/diff/1-2/
https://hg.mozilla.org/integration/mozilla-inbound/rev/f8c07a51e7ce https://hg.mozilla.org/integration/mozilla-inbound/rev/c1fb88d419ca
Comment 9•8 years ago
|
||
backed out for test failures like https://treeherder.mozilla.org/logviewer.html#?job_id=24325568&repo=mozilla-inbound
Flags: needinfo?(ato)
Comment 10•8 years ago
|
||
Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/4711cd73ee95 https://hg.mozilla.org/integration/mozilla-inbound/rev/d087c2f9a1ca
Assignee | ||
Comment 11•8 years ago
|
||
Comment on attachment 8731710 [details] MozReview Request: Bug 1257526 - Return unsupported operation error for screen orientation on desktop; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40785/diff/2-3/
Attachment #8731710 -
Attachment description: MozReview Request: Bug 1257526 - Return unsupported operation error for screen orientation on desktop; r?automatedtester → MozReview Request: Bug 1257526 - Return unsupported operation error for screen orientation on desktop; r=automatedtester
Assignee | ||
Comment 12•8 years ago
|
||
Comment on attachment 8731711 [details] MozReview Request: Bug 1257526 - Harmonise unsupported operation error usage; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40787/diff/2-3/
Attachment #8731711 -
Attachment description: MozReview Request: Bug 1257526 - Harmonise unsupported operation error usage; r?automatedtester → MozReview Request: Bug 1257526 - Harmonise unsupported operation error usage; r=automatedtester
Comment 13•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/66fd82b72d1e https://hg.mozilla.org/integration/mozilla-inbound/rev/0d344473d50f
Assignee | ||
Comment 14•8 years ago
|
||
(In reply to Carsten Book [:Tomcat] from comment #9) > backed out for test failures like > https://treeherder.mozilla.org/logviewer.html#?job_id=24325568&repo=mozilla- > inbound Sorry, my mistake. Issue was caused by a fixup to the patch.
Flags: needinfo?(ato)
Comment 15•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/66fd82b72d1e https://hg.mozilla.org/mozilla-central/rev/0d344473d50f
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Comment 16•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/c6a28b230c74 https://hg.mozilla.org/releases/mozilla-aurora/rev/89dadb7edac9
status-firefox47:
--- → fixed
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•