1257535 - [refactor] Take advantage of cli and MarionetteHarness from marionette.runtests in runluciddream.py

Status: RESOLVED WONTFIX

(Testing :: General, defect)

Description

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

This could be a good mentored bug. I think of it as a "good-second-or-third-bug".

ato writes: "TODO: make ../../marionette/harness/marionette/runtests.py importable
so we can just use cli from there.  A lot of this is copy/paste from that function."

https://hg.mozilla.org/mozilla-central/annotate/5cfc10c14aaea2a449f74dcbb366179a45442dd6/testing/luciddream/luciddream/runluciddream.py#l105

marionette.runtests is importable, so let's use it. 

To test your work locally, run |./mach luciddream|. However, updates to runluciddream.py will likely require changes in the luciddream mach command: in https://dxr.mozilla.org/mozilla-central/source/testing/luciddream/mach_commands.py

General info about luciddream is here - https://dxr.mozilla.org/mozilla-central/source/testing/luciddream/README.md

Also useful to look up examples of how MarionetteHarness is used on dxr.mozilla.org

Comment 1

[Nagma Kapoor (:nagma)]

(In reply to Maja Frydrychowicz (:maja_zf) from comment #0)
> This could be a good mentored bug. I think of it as a
> "good-second-or-third-bug".
> 
> ato writes: "TODO: make ../../marionette/harness/marionette/runtests.py
> importable
> so we can just use cli from there.  A lot of this is copy/paste from that
> function."
> 
> https://hg.mozilla.org/mozilla-central/annotate/
> 5cfc10c14aaea2a449f74dcbb366179a45442dd6/testing/luciddream/luciddream/
> runluciddream.py#l105
> 
> marionette.runtests is importable, so let's use it. 
> 
> To test your work locally, run |./mach luciddream|. However, updates to
> runluciddream.py will likely require changes in the luciddream mach command:
> in
> https://dxr.mozilla.org/mozilla-central/source/testing/luciddream/
> mach_commands.py
> 
> General info about luciddream is here -
> https://dxr.mozilla.org/mozilla-central/source/testing/luciddream/README.md
> 
> Also useful to look up examples of how MarionetteHarness is used on
> dxr.mozilla.org

Hi Maja, I would be interested in working on this bug.

Comment 2

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

I learned recently that luciddream is Tier-3 now, which means it might stop being maintained, so I'm not sure this work would be super useful. It *is* very good for learning, though. I'm happy to give feedback if you still want to work on it.

If you have questions, ask on IRC in #ateam or comment on the bug and check "Need more information from ___"

Comment 3

[Nagma Kapoor (:nagma)]

Oh okay, well if it is a good learning experience, I want to work on it for sure. I'll take all the practice I can get!

Comment 4

[Priyank Trivedi]

Hi Maja,

You mentioned in your previous comment that 'luciddream is Tier-3 now'. I'm new to mozilla development and would like to read more on Tiers, what do you mean and how are they decided upon. Please share some links to read.

Comment 5

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Hi Priyank,
A job is Tier-3 when only the team who created it monitors and follows-up on results, which means that someone outside of the team can easily "break" the job without noticing. Usually a job is set to Tier-3 when it's unmaintained or still under development. More details here: https://wiki.mozilla.org/Sheriffing/Job_Visibility_Policy#Overview_of_the_Job_Visibility_Tiers

I am taking this off the good-first-bugs list for now.