1257552 - [meta-html] Implement tests for Reps

Status: RESOLVED FIXED

(DevTools :: Shared Components, enhancement)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

We should have tests for React components rendering JS/DOM data types (aka Reps).

devtools/client/shared/components/reps/test


Honza

Comment 1

[Lin Clark [:linclark]]

I tested this out. It's awesome, but unfortunately I ran into a couple stumbling blocks.

- When trying to execute with mochitest: As soon as you use require, you get a "require is not defined" error
- When trying to execute with mocha: It chokes on object destructuring. It seems this isn't supported in Node yet (https://github.com/nodejs/node/issues/2823). We could potentially use babel just for running mocha tests.

Comment 2

[Lin Clark [:linclark]]

I added a patch in Bug 1247319 Comment 7 that has the beginnings of a Mocha test for the ObjectBox rep.

Comment 3

[Lin Clark [:linclark]]

I'm removing the dependency on the Mocha bug because we've decided to use XPCShell and mochitests for the most part. I've been doing a lot of those for web console so I can help with this.

Comment 4

[Lin Clark [:linclark]]

Once DOM Panel lands, this will be the list of reps. I think we should break each one out as a bug and turn this into a meta.

'array.js',
'attribute.js',
'caption.js',
'date-time.js',
'document.js',
'event.js',
'function.js',
'grip-array.js',
'grip.js',
'named-node-map.js',
'null.js',	
'number.js',	
'object-box.js',	
'object-link.js',	
'object-with-text.js',
'object-with-url.js',
'object.js',	
'regexp.js',
'rep-utils.js',	
'rep.js',	
'string.js',	
'stylesheet.js',
'text-node.js',
'undefined.js',
'url.js',	
'window.js',