Closed Bug 1257572 Opened 8 years ago Closed 8 years ago

Add js::AutoEnterOOMUnsafeRegion::crash to our markers for OOM signatures

Categories

(Socorro :: Backend, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: kairo, Unassigned)

References

Details

Looking at crashes like bug 1257387, we probably want to add js::AutoEnterOOMUnsafeRegion::crash to the OOMSignature rule so we actually mark those with an "OOM | ..." signature.
To repeat from the PR, from what I understand, js::AutoEnterOOMUnsafeRegion::crash is either a replacement or at least a similar thing to js::CrashAtUnhandlableOOM which we already handle, and from the name, I'm pretty sure that all of AutoEnterOOMUnsafeRegion is pretty surely OOM handling, so if we crash there, we should assign an "OOM" signature.

PR is https://github.com/mozilla/socorro/pull/3243
Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/e3ece925c5a72d7d4bd805ebdd1b3b9d1828b6c2
Fixes bug 1257572 - Add js::AutoEnterOOMUnsafeRegion::crash to our markers for OOM signatures

https://github.com/mozilla/socorro/commit/a887cadd925e8d511bbc39f70302dcdbbba0c70d
Merge pull request #3243 from KaiRo-at/master

Bug 1257572 - Add js::AutoEnterOOMUnsafeRegion::crash to our markers for OOM signatures
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.