_chrome _ext _downloads _misc .html | Cleanup function threw exception: [Exception ... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [ns IFile .remove]" nsresult: "0x80004005 (NS_ERROR_FAILURE)" location: "JS frame :: setup/< :
RESOLVED FIXED in Firefox 48
|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
58 bytes, text/x-review-board-request
|Details | Review|
These happened shortly after bug 1245641 landed, dunno if that's related.
15 automation job failures were associated with this bug yesterday. Repository breakdown: * mozilla-inbound: 9 * fx-team: 5 * mozilla-central: 1 Platform breakdown: * windows8-64: 14 * windows7-32: 1 For more details, see: https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1257581&startday=2016-03-17&endday=2016-03-17&tree=all
19 automation job failures were associated with this bug yesterday. Repository breakdown: * mozilla-inbound: 17 * fx-team: 2 Platform breakdown: * windows8-64: 16 * windows7-32: 3 For more details, see: https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1257581&startday=2016-03-18&endday=2016-03-18&tree=all
This is causing way too many failures. I'm going to disable these tests until this is fixed.
Severity: normal → critical
https://hg.mozilla.org/integration/fx-team/rev/5fca7a4520b8363e1feaf92c12470b0dacaf606c Bug 1257581: Disable test_chrome_ext_downloads_misc.html until intermittents are fixed. r=me
54 automation job failures were associated with this bug in the last 7 days. Repository breakdown: * mozilla-inbound: 34 * fx-team: 16 * mozilla-central: 3 * try: 1 Platform breakdown: * windows8-64: 45 * windows7-32: 8 * windowsxp: 1 For more details, see: https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1257581&startday=2016-03-14&endday=2016-03-20&tree=all
Ah, the erase() test carelessly does not wait for downloads to complete. This will be easy to fix once the test changes in the patch for 1245651 have landed.
Assignee: nobody → aswan
Iteration: --- → 48.2 - Apr 4
Created attachment 8735536 [details] MozReview Request: Bug 1257581 Fix and re-enable downloads misc tests r?kmag The original problem was that the erase() test did not wait for downloads to complete which caused a race with cleanup code trying to remove the download directory while downloads were still writing to it. This was fixed in https://hg.mozilla.org/mozilla-central/rev/d6d9e7411319 But meanwhile, the removeFile() test bit-rotted slightly, fixed it here and re-enabled the misc test. Review commit: https://reviewboard.mozilla.org/r/42833/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/42833/
Attachment #8735536 - Flags: review?(kmaglione+bmo)
We've got green on all platforms and 5 good tests on windows (marred by an unrelated devtools failure): https://treeherder.mozilla.org/#/jobs?repo=try&revision=e146c1d15d5f (windows was where all the intermittent failures happened previously, see comment 2 and comment 3)
Comment on attachment 8735536 [details] MozReview Request: Bug 1257581 Fix and re-enable downloads misc tests r?kmag https://reviewboard.mozilla.org/r/42833/#review39303
Attachment #8735536 - Flags: review?(kmaglione+bmo) → review+
Keywords: leave-open → checkin-needed
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.