Closed Bug 1257605 Opened 4 years ago Closed 3 years ago
_apk .py without version should fail
$ python get_apk.py --version will try to do something. We should fail with an error as no version is provided
Alex, do you want to take care of that? Thanks
Yeah, I'd work on this.
Assignee: nobody → me
Status: NEW → ASSIGNED
Review commit: https://reviewboard.mozilla.org/r/41219/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/41219/
Comment on attachment 8732536 [details] Bug 1257605 - get_apk.py without version fails. https://reviewboard.mozilla.org/r/41219/#review37869 Besides the 2 comments, works great, thanks! ::: .hgignore:111 (Diff revision 1) > ^embedding/ios/GeckoEmbed/GeckoEmbed.xcodeproj/project.xcworkspace/xcuserdata > ^embedding/ios/GeckoEmbed/GeckoEmbed.xcodeproj/xcuserdata > > # Ignore mozharness execution files > ^testing/mozharness/.tox/ > +^testing/mozharness/apk-download /apk-download => /apk-download/ (consistency with the others) ::: testing/mozharness/scripts/get_apk.py (Diff revision 1) > from mozharness.base.script import ScriptMixin > > > class GetAPK(BaseScript, VirtualenvMixin): > all_actions = [ > - 'create-virtualenv', Why are you doing this change? This should be done in a separate commit anyway
Alex, any news?
Hey, is this still being worked on :) ?
While taking the script out of mozharness (bug 1305390), argparse was used. Now, if you forget to provide an actual version, you get the following error: > 2016-11-29 14:07:27,565 - exceptions.py - CRITICAL - argument --version: expected one argument Sorry Adrian, this bug is not valid anymore. On the other hand, the error handling is not very beautiful: the exception is errored out. We could catch it and get a nicer error message. If you want to take a look, the code now lives here. I can file a new bug and help you out. Please let me know what you think of it.  https://github.com/mozilla-releng/mozapkpublisher
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 1305390
Attachment #8732536 - Attachment description: MozReview Request: Bug 1257605 - get_apk.py without version fails. r?sylvestre → Bug 1257605 - get_apk.py without version fails.
You need to log in before you can comment on or make changes to this bug.