Closed
Bug 1257616
Opened 8 years ago
Closed 8 years ago
Avoid leak if MediaPipeline is shut down after xpcom-shutdown-threads
Categories
(Core :: WebRTC, defect, P1)
Core
WebRTC
Tracking
()
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox48 | --- | affected |
People
(Reporter: jesup, Assigned: jesup)
References
Details
Attachments
(1 file, 1 obsolete file)
3.05 KB,
patch
|
drno
:
review+
|
Details | Diff | Splinter Review |
While clearly an edge case, there are some degenerate cases MediaPipeline doesn't process a shutdown until we're after xpcom-shutdown-threads, and DispatchToMainThread no longer works. Also, if we're on MainThread, there's no reason to dispatch to MainThread; we don't need to order the releases or spin the event loop first. So this patch adds code to simply delete the object directly if we're already on MainThread.
Attachment #8731808 -
Flags: review?(drno)
Assignee | ||
Updated•8 years ago
|
Rank: 10
Comment 1•8 years ago
|
||
Comment on attachment 8731808 [details] [diff] [review] We can release Conduits immediately if we're on MainThread already r=drno Review of attachment 8731808 [details] [diff] [review]: ----------------------------------------------------------------- LGTM
Attachment #8731808 -
Flags: review?(drno) → review+
Comment 3•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d1c6e59567a1
Assignee | ||
Comment 4•8 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b6865ccd6ec8 -- This sounds *so* much better. Still need to figure why it was so bad without it (underruns...) but DirectListeners for a Recorder make a lot of sense. Note this will NOT affect things like WebAudio sources.
Assignee | ||
Comment 5•8 years ago
|
||
Comment on attachment 8732394 [details] [diff] [review] Move MediaRecorder to use DirectListeners wherever possible Oops, sorry
Attachment #8732394 -
Attachment is obsolete: true
Assignee | ||
Comment 6•8 years ago
|
||
Was leave-open only because I cloned it from a leave-open bug, oops
You need to log in
before you can comment on or make changes to this bug.
Description
•