1257636 - Show "bookmarks are hidden" snackbar if needed in the migrated reading list panel

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[Andrzej Hunt :ahunt]

See:
https://bugzilla.mozilla.org/show_bug.cgi?id=1234316#c19

Filing this as a separate bug since we don't need to land this simultaneously with the main migration.

Comment 1

[Andrzej Hunt :ahunt]

Attachment: MozReview Request: Bug 1257636 - Show "bookmarks are hidden" snackbar if necessary in migrated reading list panel r?liuche

Review commit: https://reviewboard.mozilla.org/r/45567/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/45567/

Comment 2

[Chenxia Liu [:liuche]]

Comment on attachment 8740108 [details]
MozReview Request: Bug 1257636 - Show "bookmarks are hidden" snackbar if necessary in migrated reading list panel r?liuche

https://reviewboard.mozilla.org/r/45567/#review42147

Minor comments.

::: mobile/android/base/java/org/mozilla/gecko/home/ReadingListPanel.java:39
(Diff revision 1)
>          // We could update the ID names - however this panel is only intended to be live for one
>          // release, hence there's little utility in optimising this code.
>          root.findViewById(R.id.welcome_account).setOnClickListener(new View.OnClickListener() {
>              @Override
>              public void onClick(View v) {
> +                boolean areBookmarksEnabled = GeckoSharedPrefs.forProfile(getContext()).getBoolean(HomeConfig.PREF_KEY_BOOKMARKS_PANEL_ENABLED, true);

I find this "are" very odd - can you just make it bookmarksEnabled?

::: mobile/android/base/locales/en-US/android_strings.dtd:30
(Diff revision 1)
>  <!ENTITY  onboard_start_restricted1 "Stay safe and in control with this simplified version of &brandShortName;.">
>  
>  <!ENTITY  reading_list_migration_title "Reading List connected">
>  <!ENTITY  reading_list_migration_subtext "Your Reading List items will now be added to your Bookmarks">
>  <!ENTITY  reading_list_migration_goto_bookmarks "Go to Bookmarks">
> +<!ENTITY  reading_list_migration_bookmarks_hidden "Your Bookmarks panel has been hidden">

Did we discuss this string? I feel like this particular string could be very confusing because it could associate the action "click link" to "bookmarks has been hidden" in a causation order. Something more like "Your Bookmarks panel is hidden" or "Your Bookmarks panel is not enabled" or "Enable your Bookmarks panel"?

Comment 3

[Andrzej Hunt :ahunt]

https://hg.mozilla.org/integration/fx-team/rev/a2de4083a303b3bcc9bc3745b196e6cf0db5cc94
Bug 1257636 - Show "bookmarks panel is hidden" snackbar if necessary in migrated reading list panel r=liuche

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a2de4083a303

Comment 5

[Teodora Vermesan (:TeoVermesan)]

If "Bookmarks" panel is hidden, tapping "Go to Bookmarks" from Reading List panel, will display "Your Bookmarks panel is hidden" snackbar:
Verified as fixed using:
Device: Nexus 6 (Android 6.0)
Build: Firefox for Android 48.0a1 (2016-04-13)