Closed
Bug 1257648
Opened 8 years ago
Closed 8 years ago
Fennec artifact builds are busted because Android package names changed from *android-arm* to *androideabi-arm*
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox48 fixed)
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: nalexander, Assigned: glandium)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
First push to mozilla-inbound showing this is https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=8266c4f82c1a. This is breaking Android artifact builds and will likely have changed the constants sent to our metrics and Telemetry collection, so we either need to rollback to earlier definitions or prepare to change what we expect.
Assignee | ||
Comment 1•8 years ago
|
||
So the reason this is happening is that config.sub does some more normalization, and we don't run config.sub in pyconfigure. I guess until we stop using TARGET_CPU and TARGET_OS, we should use config.sub to normalize them.
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → mh+mozilla
Assignee | ||
Comment 2•8 years ago
|
||
Until we stop relying on the raw_cpu and raw_os values from target and host, we need to keep normalizing them like old-configure.in did, which involves filtering them through config.sub. Review commit: https://reviewboard.mozilla.org/r/40905/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/40905/
Attachment #8731884 -
Flags: review?(nalexander)
Reporter | ||
Comment 3•8 years ago
|
||
Comment on attachment 8731884 [details] MozReview Request: Bug 1257648 - Always filter target/host triplets with config.sub https://reviewboard.mozilla.org/r/40905/#review37447 Output of `./mach configure ; ./mach environment -v | grep TARGET_` before: TARGET_CPU = arm TARGET_OS = androideabi ANDROID_TARGET_SDK: 23 MOZ_LIBSTDCXX_TARGET_VERSION: TARGET_CPU: arm TARGET_OS: androideabi TARGET_XPCOM_ABI: ANDROID_TARGET_SDK after: TARGET_CPU = arm TARGET_OS = android ANDROID_TARGET_SDK: 23 MOZ_LIBSTDCXX_TARGET_VERSION: TARGET_CPU: arm TARGET_OS: android TARGET_XPCOM_ABI: ANDROID_TARGET_SDK I can't verify that |mach artifact install| works since the actual upstream files are badly named, but this should start generating new ones correctly.
Attachment #8731884 -
Flags: review?(nalexander) → review+
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2a0affe3d0c6
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•