Closed Bug 1257686 Opened 4 years ago Closed 4 years ago

Toolbar does not appear in fullscreen mode with flash content

Categories

(Firefox :: General, defect)

48 Branch
x86_64
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: over68, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: regression)

Attachments

(1 file)

Steps to reproduce:

1. Go to https://dl.dropboxusercontent.com/u/95157096/85f61cf7/bt9z86dwun.swf.
2. Switch to fullscreen mode.
3. Move mouse up to the very top edge of the content.


Actual results:

Toolbar does not appear in fullscreen mode with flash content.
Flags: needinfo?(alice0775)
Xidorn, can you look into this, please?
Flags: needinfo?(quanxunzhen)
Flags: needinfo?(alice0775)
Status: UNCONFIRMED → NEW
Ever confirmed: true
Ah, so the plugin window covers the whole window, and thus the toggler cannot get mouse event at all...
I don't see any easy way to fix this... we'll probably need to backout bug 729011 if we think this is a more important issue...
(In reply to Xidorn Quan [:xidorn] (UTC+8) from comment #4)
> I don't see any easy way to fix this... we'll probably need to backout bug
> 729011 if we think this is a more important issue...

Can we detect the flash case separately and use the "old" method in that case? Or force the fullscreen flash thing to be 1px smaller still?
Maybe fullscreen windowed flash? The fullscr-toggler could cover windowless flash.
(In reply to :Gijs Kruitbosch from comment #5)
> Can we detect the flash case separately and use the "old" method in that
> case? Or force the fullscreen flash thing to be 1px smaller still?

I don't think the latter is possible. Pages can put Flash on the very top, which would lead to the same issue here. Also site can have a full page Flash rather than a single Flash file. Both of these cases are not very rare according to my experience.

We probably can detect whether there is any plugin inside the page, and react accordingly... I may have some idea, but wonder whether it's worth the effort...

(In reply to Masatoshi Kimura [:emk] from comment #6)
> Maybe fullscreen windowed flash? The fullscr-toggler could cover windowless
> flash.

I guess so. I think content can control whether Flash is windowed or not, right?
(In reply to Xidorn Quan [:xidorn] (UTC+8) from comment #7)
> We probably can detect whether there is any plugin inside the page, and
> react accordingly... I may have some idea, but wonder whether it's worth the
> effort...

I think with the push to reduce the use of NPAPI plugins, and replacing flash with html5, giving a better experience to html5 than to flash is fine. I don't think it's fine that webpages can make it hard to exit fullscreen just by using flash. Of course, I don't know how much effort you're talking about when you say you have some idea. :-)

But, to be clear, personally I think the choice is between backing out the other bug, or "fixing" this in some way specifically for flash / npapi.
Duplicate of this bug: 1258184
It seems to me there is still some rendering issue when showing the toolbar. But I suppose that's a different problem.
Flags: needinfo?(quanxunzhen)
Hmmm, this probably doesn't work if the plugin is added after the navbar is hidden...
Comment on attachment 8733176 [details]
MozReview Request: Bug 1257686 - Push the content down by one pixel for fullscreen mode when there is any plugin. r?dao

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/41625/diff/1-2/
Attachment #8733176 - Attachment description: MozReview Request: Bug 1257686 - Push the content down by one pixel for fullscreen mode when there is any plugin. r?dao → MozReview Request: Bug 1257686 - Force display toolbar for fullscreen mode if there is any plugin in the page. r?dao
This patch would fix both this and bug 1258184 as we refuse to hide toolbar if there is any plugin used in the page. (I guess there would be more bugs being filed for this behavior... but I guess this is the best action we can take for now, if we do not want to backout bug 729011.)
But if the plugin content is a movie, I'd like to show the movie without the chrome. The reason why I'd like to do that is, fullscreen mode of plugin is existed when another window gets focus. This very annoying issue when I want to play a video in secondary display like TV.
Comment on attachment 8733176 [details]
MozReview Request: Bug 1257686 - Push the content down by one pixel for fullscreen mode when there is any plugin. r?dao

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/41625/diff/2-3/
Attachment #8733176 - Attachment description: MozReview Request: Bug 1257686 - Force display toolbar for fullscreen mode if there is any plugin in the page. r?dao → MozReview Request: Bug 1257686 - Push the content down by one pixel for fullscreen mode when there is any plugin. r?dao
OK, then let's try the previous way again.
Comment on attachment 8733176 [details]
MozReview Request: Bug 1257686 - Push the content down by one pixel for fullscreen mode when there is any plugin. r?dao

The dependency on the click-to-play-plugins notification doesn't feel right. There's no API specifying that this check does and will continue to do what we want here. It's essentially a dependency on UI behavior from a completely unrelated area of code.

I suppose we could introduce a more intentional way to check if a plugin is present. Then again, this might be over-engineering it. We could also just back bug 729011 out and wait till NPAPI and/or windowed flash have been killed (that's still the plan, right?).
Attachment #8733176 - Flags: review?(dao) → review-
OK, I guess it's safe to backout bug 729011. The original hack for bug 799523 should have been fixed by bug 1244546 in another way.
Backed out bug 729011 on https://hg.mozilla.org/integration/mozilla-inbound/rev/b3d95f2926e6ca7011ea1a32288f04e22337b0dd
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.