Closed
Bug 1257725
Opened 8 years ago
Closed 8 years ago
Try to eliminate uses of ThreadsafeAutoJSContext
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(6 files)
5.03 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
3.97 KB,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
3.05 KB,
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
2.96 KB,
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
38.27 KB,
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
2.38 KB,
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
It behaves differently on workers and mainthread if not called from JS, or will once I land the fix for bug 1255817. So we need to either make that case MOZ_CRASH/assert, or we should just nix this class. We'll see if I can pass around enough JSContexts....
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8733064 -
Flags: review?(bugs)
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•8 years ago
|
||
Attachment #8733065 -
Flags: review?(amarchesini)
Assignee | ||
Comment 3•8 years ago
|
||
Attachment #8733066 -
Flags: review?(bobbyholley)
Assignee | ||
Comment 4•8 years ago
|
||
Attachment #8733067 -
Flags: review?(khuey)
Assignee | ||
Comment 5•8 years ago
|
||
Attachment #8733068 -
Flags: review?(khuey)
Assignee | ||
Comment 6•8 years ago
|
||
Attachment #8733069 -
Flags: review?(bobbyholley)
Updated•8 years ago
|
Attachment #8733065 -
Flags: review?(amarchesini) → review+
Comment 7•8 years ago
|
||
Comment on attachment 8733064 [details] [diff] [review] part 1. Get rid of ThreadsafeAutoJSContext usage in JSEventHandler::HandleEvent > for m in descriptor.interface.members: > if m.isAttr(): >+ if m.type.isAny(): >+ # Add a getter that doesn't need a JSContext >+ extraMethods.append( >+ ClassMethod( >+ CGSpecializedGetter.makeNativeName(descriptor, m), >+ "void", >+ [Argument("JS::MutableHandle<JS::Value>", >+ "aRetVal")], >+ const=True, >+ body=fill( >+ """ >+ JS::ExposeValueToActiveJS(${memberName}); >+ aRetVal.set(${memberName}); >+ """, >+ memberName=CGDictionary.makeMemberName(m.identifier.name)))) > if getattr(m, "originatingInterface", > descriptor.interface) != descriptor.interface: > continue originatingInterface stuff should be before the new stuff. with that r+
Attachment #8733064 -
Flags: review?(bugs) → review+
Updated•8 years ago
|
Attachment #8733066 -
Flags: review?(bobbyholley) → review+
Comment 8•8 years ago
|
||
Comment on attachment 8733069 [details] [diff] [review] part 6. Get rid of ThreadsafeAutoJSContext Review of attachment 8733069 [details] [diff] [review]: ----------------------------------------------------------------- \o/
Attachment #8733069 -
Flags: review?(bobbyholley) → review+
Assignee | ||
Comment 9•8 years ago
|
||
> originatingInterface stuff should be before the new stuff.
Good catch, done.
Attachment #8733067 -
Flags: review?(khuey) → review+
Attachment #8733068 -
Flags: review?(khuey) → review+
Comment 10•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/d64c9c578559 https://hg.mozilla.org/integration/mozilla-inbound/rev/12c94a351403 https://hg.mozilla.org/integration/mozilla-inbound/rev/6c701e2a3047 https://hg.mozilla.org/integration/mozilla-inbound/rev/16ddfdbf6ff4 https://hg.mozilla.org/integration/mozilla-inbound/rev/30e2a55c26ee https://hg.mozilla.org/integration/mozilla-inbound/rev/2c3ebed96686
Comment 11•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d64c9c578559 https://hg.mozilla.org/mozilla-central/rev/12c94a351403 https://hg.mozilla.org/mozilla-central/rev/6c701e2a3047 https://hg.mozilla.org/mozilla-central/rev/16ddfdbf6ff4 https://hg.mozilla.org/mozilla-central/rev/30e2a55c26ee https://hg.mozilla.org/mozilla-central/rev/2c3ebed96686
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•