1257730 - Crash with <a ping> and changing <base href>

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[Jesse Ruderman]

Attachment: testcase

Testcase requires:
  user_pref("browser.send_pings", true);

Crashing line was added in:
  http://hg.mozilla.org/mozilla-central/rev/fa170734154a#l1.66

Comment 1

[Jesse Ruderman]

Attachment: stack

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Christoph, could you take a look.

Comment 3

[Christoph Kerschbaumer [:ckerschb}]

Yeah, will fix that up.

Comment 4

[Christoph Kerschbaumer [:ckerschb}]

Attachment: bug_1257730_fix_ping.patch

Thanks Jesse for the testcase.

Jonas, in the old version there was a null check for the uri here [1], we should make sure we don't deref a nullptr in the new version as well.

[1] http://hg.mozilla.org/mozilla-central/rev/fa170734154a#l1.15

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Any reason we aren't landing the test as a crashtest too?

Comment 6

[Christoph Kerschbaumer [:ckerschb}]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #5)
> Any reason we aren't landing the test as a crashtest too?

You are right. I'll convert the test into a crashtest and we should land that too. thanks!

Comment 7

[Christoph Kerschbaumer [:ckerschb}]

Attachment: bug_1257730_ping_crashtest.patch

Fails without the patch, but works correctly (no crash) with the patch.

Ryan, to speed things up I think it's fine if you review the test, right?

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/147b57e8c949
https://hg.mozilla.org/integration/mozilla-inbound/rev/10d8bc81030b

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/147b57e8c949
https://hg.mozilla.org/mozilla-central/rev/10d8bc81030b