Closed Bug 1257741 Opened 8 years ago Closed 8 years ago

[TV] The error string disappear in network error page

Categories

(Firefox OS Graveyard :: Gaia::TV::System, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::TV::System
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: danhuang, Assigned: danhuang)

References

Details

Attachments

(1 file)

[gaia] danhuang1202:1257741_neterror_string_disapear > mozilla-b2g:master
46 bytes, text/x-github-pull-request
rexboy
: review+
Details | Review 
The string didn't display well in network error page at browser app and web app.
Assignee: nobody → dhuang
Blocks: 1256202, 1256203, 1256204
Depends on: 1247710
Comment on attachment 8732004 [details] [review]
[gaia] danhuang1202:1257741_neterror_string_disapear > mozilla-b2g:master

Hi Rex, please help review. This patch create net error page when l10 is ready. Thanks.
Attachment #8732004 - Flags: review?(rexboy)
Comment on attachment 8732004 [details] [review]
[gaia] danhuang1202:1257741_neterror_string_disapear > mozilla-b2g:master

Looks good.
Attachment #8732004 - Flags: review?(rexboy) → review+
Thanks for the review.
Merge in master: https://github.com/mozilla-b2g/gaia/commit/6d4d65742ff3fb29b230585c6eed72e1f1249a64
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: