Adjust step numbering in scripted proxy code to be ES6-correct

RESOLVED FIXED in Firefox 48

Status

()

defect
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: Waldo, Assigned: Waldo)

Tracking

unspecified
mozilla48
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox48 fixed)

Details

Attachments

(1 attachment)

Split out of bug 1257102.
Posted patch PatchSplinter Review
Attachment #8732028 - Flags: review?(evilpies)
Blocks: 1257779
Comment on attachment 8732028 [details] [diff] [review]
Patch

Review of attachment 8732028 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/proxy/ScriptedDirectProxyHandler.cpp
@@ +68,2 @@
>      if (!current.configurable()) {
> +        // Step 5a.

I like to write 5.a., just because 5aii would get confusing.

@@ +235,5 @@
>          return PreventExtensions(cx, target, result);
>  
> +    // Step 7.
> +    bool booleanTrapResult;
> +    {

Is there some reason for using a new block in this case?

@@ +252,5 @@
> +        // Step 8a.
> +        bool targetIsExtensible;
> +        if (!IsExtensible(cx, target, &targetIsExtensible))
> +            return false;
> +

// Step 8.b.

@@ +746,5 @@
>          value
>      };
>      RootedValue trapResult(cx);
>      if (!Invoke(cx, ObjectValue(*handler), trap, ArrayLength(argv), argv, &trapResult))
>          return false;

bool booleanTrapResult = .. Maybe? Your call.

@@ +818,2 @@
>          if (desc.object()) {
> +            // Step 9b(i).

Yeah, see. 9.b.i.
Attachment #8732028 - Flags: review?(evilpies) → review+
Uhh so this should be ES8 and not ES7?! https://github.com/tc39/ecma262/issues/483
https://hg.mozilla.org/mozilla-central/rev/ca17f9480153
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.