1257758 - Adjust step numbering in scripted proxy code to be ES6-correct

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jeff Walden [:Waldo]]

Split out of bug 1257102.

Comment 1

[Jeff Walden [:Waldo]]

Attachment: Patch

Comment 2

[Tom S. (please needinfo tschuster)]

Comment on attachment 8732028 [details] [diff] [review]
Patch

Review of attachment 8732028 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/proxy/ScriptedDirectProxyHandler.cpp
@@ +68,2 @@
>      if (!current.configurable()) {
> +        // Step 5a.

I like to write 5.a., just because 5aii would get confusing.

@@ +235,5 @@
>          return PreventExtensions(cx, target, result);
>  
> +    // Step 7.
> +    bool booleanTrapResult;
> +    {

Is there some reason for using a new block in this case?

@@ +252,5 @@
> +        // Step 8a.
> +        bool targetIsExtensible;
> +        if (!IsExtensible(cx, target, &targetIsExtensible))
> +            return false;
> +

// Step 8.b.

@@ +746,5 @@
>          value
>      };
>      RootedValue trapResult(cx);
>      if (!Invoke(cx, ObjectValue(*handler), trap, ArrayLength(argv), argv, &trapResult))
>          return false;

bool booleanTrapResult = .. Maybe? Your call.

@@ +818,2 @@
>          if (desc.object()) {
> +            // Step 9b(i).

Yeah, see. 9.b.i.

Comment 3

[Tom S. (please needinfo tschuster)]

Uhh so this should be ES8 and not ES7?! https://github.com/tc39/ecma262/issues/483

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ca17f9480153

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ca17f9480153