Closed
Bug 1257758
Opened 8 years ago
Closed 8 years ago
Adjust step numbering in scripted proxy code to be ES6-correct
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: Waldo, Assigned: Waldo)
References
Details
Attachments
(1 file)
36.47 KB,
patch
|
evilpie
:
review+
|
Details | Diff | Splinter Review |
Split out of bug 1257102.
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8732028 -
Flags: review?(evilpies)
Comment 2•8 years ago
|
||
Comment on attachment 8732028 [details] [diff] [review] Patch Review of attachment 8732028 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/proxy/ScriptedDirectProxyHandler.cpp @@ +68,2 @@ > if (!current.configurable()) { > + // Step 5a. I like to write 5.a., just because 5aii would get confusing. @@ +235,5 @@ > return PreventExtensions(cx, target, result); > > + // Step 7. > + bool booleanTrapResult; > + { Is there some reason for using a new block in this case? @@ +252,5 @@ > + // Step 8a. > + bool targetIsExtensible; > + if (!IsExtensible(cx, target, &targetIsExtensible)) > + return false; > + // Step 8.b. @@ +746,5 @@ > value > }; > RootedValue trapResult(cx); > if (!Invoke(cx, ObjectValue(*handler), trap, ArrayLength(argv), argv, &trapResult)) > return false; bool booleanTrapResult = .. Maybe? Your call. @@ +818,2 @@ > if (desc.object()) { > + // Step 9b(i). Yeah, see. 9.b.i.
Attachment #8732028 -
Flags: review?(evilpies) → review+
Comment 3•8 years ago
|
||
Uhh so this should be ES8 and not ES7?! https://github.com/tc39/ecma262/issues/483
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ca17f9480153
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•