Closed Bug 1257760 Opened 4 years ago Closed 4 years ago

[Mac] plugins shouldn't consume reserved shortcut keys of chrome

Categories

(Core :: Plug-ins, defect)

All
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
This is a partially regression of bug 1110888.
Blocks: 1110888
When a plugin has focus, TextInputHandler shouldn't send native keydown event to interpretKeyEvents of NSView.  However, it should dispatch keypress events because shortcut key handlers wait following keypress event.

Review commit: https://reviewboard.mozilla.org/r/42379/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/42379/
Attachment #8734591 - Flags: review?(m_kato)
Attachment #8734591 - Flags: review?(m_kato) → review+
Comment on attachment 8734591 [details]
MozReview Request: Bug 1257760 TextInputHandler should dispatch keypress event even when a plugin has focus r?m_kato

https://reviewboard.mozilla.org/r/42379/#review39093
https://hg.mozilla.org/mozilla-central/rev/d9ab9ff08b5e
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.