Closed Bug 1257801 Opened 8 years ago Closed 8 years ago

The new sync button on Firefox 45 does not work when the navigation toolbar is hidden

Categories

(Firefox :: Sync, defect)

45 Branch
x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 1227540

People

(Reporter: janus, Unassigned)

References

Details

(Whiteboard: [need testcase])

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Firefox/45.0
Build ID: 20160308181531

Steps to reproduce:

I have the navigation toolbar hid because I use Vimperator, so I moved the new sync button to the tabs toolbar. 


Actual results:

When I press the sync button nothing happens, unless I unhide the navigation toolbar, in such case the button works as expected.


Expected results:

The sync button should show the synced tabs from other devices and the sync now option, even then the navigation toolbar is hidden.
OS: Unspecified → Linux
Hardware: Unspecified → x86_64
Component: Untriaged → Sync
New information: the problem is still there in 45.0.1, and I also tested 47.0a2 (2016-03-19), using the "hide navigation bar" addon instead of vimperator, with the same undesired result.
(In reply to janus from comment #1)
> New information: the problem is still there in 45.0.1, and I also tested
> 47.0a2 (2016-03-19), using the "hide navigation bar" addon instead of
> vimperator, with the same undesired result.

I installed that addon and it works fine for me - I can move the button to either the tab strip or the menu and it works fine whether the navbar is shown or not.

It might help to look in the "browser console" for error messages, but I can't reproduce this.
Whiteboard: [need testcase]
> It might help to look in the "browser console" for error messages, but I
> can't reproduce this.

You are right. I started Firefox 45.0.1 with a new profile and installed the "hide navigation bar" addon, and it still works. However, when you press on the sync button the navigation bar appears again.
So, to reproduce the problem as I first reported it you can follow the following steps:

1. Start with a new fresh profile
2. Move the sync button to the tabs strip
3. Install the vimperator addon
4. Press ":" to access vimperator command line and type "set gui=nonavigation". That will hide the navigation bar and not show it again even when you press the sync button.

So, the problem seems to be that the sync button needs to "see" the navigation bar, and the "hide navigation bar" addon shows it so it can work, while vimperator does not. The question is: Is vimperator who have to change its behaviour or Firefox should not make depend sync from the navbar?
PS: the browser console does not show any error when I press the sync button
Reduced STR:
Add the line #nav-bar { display: none !important; } to the userChrome.css file.

Result: with navbar hidden, the new Sync tab menu tooltip doens't appear.
Status: UNCONFIRMED → NEW
Has Regression Range: --- → yes
Has STR: --- → yes
Ever confirmed: true
Keywords: regression, testcase
Whiteboard: [need testcase]
This is essentially a duplicate of bug 1227540. Firefox no longer (since Australis / version 29) supports hiding the navigation toolbar. We got rid of the "open location" dialog and a number of other things that used to have to deal with it not being there. Vimperator should find a way of hiding the toolbar that doesn't destroy the relevant XBL bindings, or get rid of the feature.

If that's somehow not possible, I could be convinced to r+ a patch to move the dynamically generated panel out of the navbar into the main popupset for code cleanliness reasons, but that would potentially require significant CSS and JS work, because right now all toolbar buttons in it still have the styling they'd have if they were in the navbar, which would obviously not be the case if we took the panel out. I tried it when Australis was still being developed and gave up fairly quickly as there were bigger fish to fry. One of life's regrets. :-)
Status: NEW → RESOLVED
Has Regression Range: yes → ---
Has STR: yes → ---
Closed: 8 years ago
Keywords: regression, testcase
Resolution: --- → DUPLICATE
Whiteboard: [need testcase]
Thank you for the information. I just open a bug report at Vimperator:
https://github.com/vimperator/vimperator-labs/issues/465
Solution for Vimperator users: (from https://github.com/chrisaljoudi/uBlock/issues/720)
Just set
style -name ublick * #nav-bar * { visibility: visible; }
You need to log in before you can comment on or make changes to this bug.