Closed
Bug 1257809
Opened 8 years ago
Closed 8 years ago
Improve telemetry for PR_Connect
Categories
(Core :: Networking, defect)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla48
People
(Reporter: dragana, Assigned: dragana)
Details
(Whiteboard: [necko-active])
Attachments
(1 file)
18.46 KB,
patch
|
mcmanus
:
review+
|
Details | Diff | Splinter Review |
We should separate telemetry for not successful connects. Successful connections will return after max 200-500ms but to detect a problem, like a blocking socket it is better to look only at not successful connects. Also do not record telemetry if computer is going to sleep.
Assignee | ||
Comment 1•8 years ago
|
||
Note: telemetry is now limited to 100 (for more approval from telemetry people is need). I think we do not need more than that...
Attachment #8732508 -
Flags: review?(mcmanus)
Assignee | ||
Comment 2•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e95399ecefba
Comment 3•8 years ago
|
||
Tracking since we're hoping this may help diagnose a topcrash in 46.0b2.
status-firefox46:
--- → affected
tracking-firefox46:
--- → +
Comment 4•8 years ago
|
||
Crash described here: https://bugzilla.mozilla.org/show_bug.cgi?id=1158189#c71
Updated•8 years ago
|
Attachment #8732508 -
Flags: review?(mcmanus) → review+
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 5•8 years ago
|
||
Let me know with needinfo and an approval request if you want to uplift this to beta. We could get it into build 5 tomorrow morning if it lands on m-c and looks ok there. Thanks!
Flags: needinfo?(dd.mozilla)
Assignee | ||
Comment 6•8 years ago
|
||
(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #5) > Let me know with needinfo and an approval request if you want to uplift this > to beta. We could get it into build 5 tomorrow morning if it lands on m-c > and looks ok there. Thanks! This patch is only for telemetry, it will not fix any problem, just give us some data. We do not need to uplift this one. I would like to uplift bugs 1257216 and 1259089, they maybe have some influence on the crashes. I will nominate them as soon as they land on m-c
Flags: needinfo?(dd.mozilla)
Comment 8•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2c55fae81acc
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Comment 9•8 years ago
|
||
Liz: given we don't want to uplift this, should it still be tracking 46?
Flags: needinfo?(lhenry)
Comment 10•8 years ago
|
||
No, we don't need to track. Thanks Jason.
You need to log in
before you can comment on or make changes to this bug.
Description
•