Closed Bug 1257809 Opened 8 years ago Closed 8 years ago

Improve telemetry for PR_Connect

Categories

(Core :: Networking, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox46 - wontfix
firefox48 --- fixed

People

(Reporter: dragana, Assigned: dragana)

Details

(Whiteboard: [necko-active])

Attachments

(1 file)

We should separate telemetry for not successful connects. Successful connections will return after max 200-500ms but to detect a problem, like a blocking socket it is better to look only at not successful connects.

Also do not record telemetry if computer is going to sleep.
Note: telemetry is now limited to 100 (for more approval from telemetry people is need). I think we do not need more than that...
Attachment #8732508 - Flags: review?(mcmanus)
Tracking since we're hoping this may help diagnose a topcrash in 46.0b2.
Attachment #8732508 - Flags: review?(mcmanus) → review+
Keywords: checkin-needed
Let me know with needinfo and an approval request if you want to uplift this to beta.  We could get it into build 5 tomorrow morning if it lands on m-c and looks ok there.  Thanks!
Flags: needinfo?(dd.mozilla)
(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #5)
> Let me know with needinfo and an approval request if you want to uplift this
> to beta.  We could get it into build 5 tomorrow morning if it lands on m-c
> and looks ok there.  Thanks!

This patch is only for telemetry, it will not fix any problem, just give us some data. We do not need to uplift this one.

I would like to uplift bugs 1257216 and 1259089, they maybe have some influence on the crashes. I will nominate them as soon as they land on m-c
Flags: needinfo?(dd.mozilla)
https://hg.mozilla.org/mozilla-central/rev/2c55fae81acc
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Liz: given we don't want to uplift this, should it still be tracking 46?
Flags: needinfo?(lhenry)
No, we don't need to track. Thanks Jason.
Flags: needinfo?(lhenry)
You need to log in before you can comment on or make changes to this bug.