Closed Bug 1257872 Opened 8 years ago Closed 8 years ago

Use libpdu in bluetoothd

Categories

(Firefox OS Graveyard :: Bluetooth, defect)

Product:
Firefox OS Graveyard
Component:
Bluetooth
Platform:
All
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: tzimmermann, Assigned: tzimmermann)

References

Details

Attachments

(1 file)

Github pull request
65 bytes, text/x-github-pull-request
brsun
: review+
Details | Review 
Libpdu contains helpers for reading and writing B2G daemon PDUs. Its code was originally developed as part of bluetoothd, so bluetoothd should make use of libpdu.
Comment on attachment 8732207 [details] [review]
Github pull request

Hi,

the API and implementation of libpdu is more or less the same as in bluetoothd. The only difference is that the cleanup functions for the buffers are now called 'destroy_*' instead of 'cleanup_*'
Attachment #8732207 - Flags: review?(brsun)
Comment on attachment 8732207 [details] [review]
Github pull request

LGTM
Attachment #8732207 - Flags: review?(brsun) → review+
Thanks Bruce!
Comment on attachment 8732207 [details] [review]
Github pull request

Updated Github pull request

  - rebased onto bug 1223732
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: