1257892 - Fix the propagation of nsIExceptions out of JS-implemented XPCOM things

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Boris Zbarsky [:bzbarsky]]

This is silly.  Say a JS-implemented XPCOM thing throws an nsIException (e.g. via throw Components.Exception(stuff)).  We land in nsXPCWrappedJSClass::CheckForException which calls XPCConvert::JSValToXPCException.

This tries to check the value for being an nsIException, but only considers XPCWrappedNatives.  So we end up taking the XPCWrappedJS codepath instead of finding our already-existing exception.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix XPCConvert::JSValToXPCException to correctly detect Web IDL binding exceptions (i.e. all of them now!) when trying to check whether the value is already an XPCException

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3cdd3f35f65e

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3cdd3f35f65e