125790 - selfserv leaks the 'nickName' and 'passwd' strings

Status: RESOLVED FIXED

(NSS :: Tools, defect, P2)

Description

[Wan-Teh Chang]

The main() function of selfserv.c calls strdup() to allocate
the 'nickName' and 'passwd' strings, but they are not freed.

Comment 1

[Wan-Teh Chang]

Attachment: Proposed patch

I free these two strings right before NSS_Shutdown(), assuming NSS
does not hold references to the nickName and passwd strings.  Is
that okay, or should I free them after NSS_Shutdown()?

Two notes:
1. free() is used to free strings allocated by strdup().
2. I did not bother to check nickName and passwd for NULL.  Passing
NULL to free() is a no-op.

Comment 2

[Wan-Teh Chang]

Fix checked in. (r=mcgreer)