Migrate mozIntl to a standalone version

RESOLVED FIXED

Status

Firefox OS
Gaia::L10n
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: gandalf, Assigned: gandalf)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
I'm migrating mozIntl to be a standalone library - https://github.com/l20n/mozintl

It'll be much easier to keep it up to date with the spec progress, and it may be useful outside of Gaia.

I'd like to migrate the shared/js/moz_intl.js soon to use the new version.
Created attachment 8732440 [details] [review]
[gaia] zbraniecki:1257905-migrate-to-new-mozintl > mozilla-b2g:master
(Assignee)

Comment 2

2 years ago
Comment on attachment 8732440 [details] [review]
[gaia] zbraniecki:1257905-migrate-to-new-mozintl > mozilla-b2g:master

Stas, sorry to bother you, but can you review this?

For moz_intl.js, please, look at the source here: https://github.com/l20n/mozintl because I had to babel transform because gaia's build system complains about 'extends' being used in the non-transpiled file.
Attachment #8732440 - Flags: review?(stas)
No bother at all.  I've had a first look and I have a few questions:

 - would you like me to review the code in l20n/mozintl as well, or just the changes to Gaia apps?
 - I'm worried about changes to some of the existing localization files;  what do you think we should do about them to ensure they're updated by localizers?
(Assignee)

Comment 4

2 years ago
>  - would you like me to review the code in l20n/mozintl as well, or just the changes to Gaia apps?

I don't think I need you to review too much of mozintl. I'd be happy if you took a bird-eye look at mozIntl source repo, but that's not blocking this bug

> - I'm worried about changes to some of the existing localization files;  what do you think we should do about them to ensure they're updated by localizers?

I'll update IDs
(Assignee)

Updated

2 years ago
Assignee: nobody → gandalf
Comment on attachment 8732440 [details] [review]
[gaia] zbraniecki:1257905-migrate-to-new-mozintl > mozilla-b2g:master

Great work, r=me.  I'd consider renaming mozintl's format() to something else so that it cannot be confused with real Intl's format() which has a different return type, but this might be outside of the scope of this bug.
Attachment #8732440 - Flags: review?(stas) → review+
(Assignee)

Comment 6

2 years ago
Yeah, good call.

I'll be iterating over mozIntl and will consider the method name switch for the next iteration.

Thanks!
Commit: https://github.com/mozilla-b2g/gaia/commit/d7c56cb9e7f489d983e87ded0da0548a6c03d1d0
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED

Updated

2 years ago
Blocks: 1264883
You need to log in before you can comment on or make changes to this bug.