Closed
Bug 1257905
Opened 8 years ago
Closed 8 years ago
Migrate mozIntl to a standalone version
Categories
(Firefox OS Graveyard :: Gaia::L10n, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: zbraniecki, Assigned: zbraniecki)
References
Details
Attachments
(1 file)
I'm migrating mozIntl to be a standalone library - https://github.com/l20n/mozintl It'll be much easier to keep it up to date with the spec progress, and it may be useful outside of Gaia. I'd like to migrate the shared/js/moz_intl.js soon to use the new version.
Comment 1•8 years ago
|
||
Assignee | ||
Comment 2•8 years ago
|
||
Comment on attachment 8732440 [details] [review] [gaia] zbraniecki:1257905-migrate-to-new-mozintl > mozilla-b2g:master Stas, sorry to bother you, but can you review this? For moz_intl.js, please, look at the source here: https://github.com/l20n/mozintl because I had to babel transform because gaia's build system complains about 'extends' being used in the non-transpiled file.
Attachment #8732440 -
Flags: review?(stas)
Comment 3•8 years ago
|
||
No bother at all. I've had a first look and I have a few questions: - would you like me to review the code in l20n/mozintl as well, or just the changes to Gaia apps? - I'm worried about changes to some of the existing localization files; what do you think we should do about them to ensure they're updated by localizers?
Assignee | ||
Comment 4•8 years ago
|
||
> - would you like me to review the code in l20n/mozintl as well, or just the changes to Gaia apps? I don't think I need you to review too much of mozintl. I'd be happy if you took a bird-eye look at mozIntl source repo, but that's not blocking this bug > - I'm worried about changes to some of the existing localization files; what do you think we should do about them to ensure they're updated by localizers? I'll update IDs
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → gandalf
Comment 5•8 years ago
|
||
Comment on attachment 8732440 [details] [review] [gaia] zbraniecki:1257905-migrate-to-new-mozintl > mozilla-b2g:master Great work, r=me. I'd consider renaming mozintl's format() to something else so that it cannot be confused with real Intl's format() which has a different return type, but this might be outside of the scope of this bug.
Attachment #8732440 -
Flags: review?(stas) → review+
Assignee | ||
Comment 6•8 years ago
|
||
Yeah, good call. I'll be iterating over mozIntl and will consider the method name switch for the next iteration. Thanks! Commit: https://github.com/mozilla-b2g/gaia/commit/d7c56cb9e7f489d983e87ded0da0548a6c03d1d0
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•