Abort network loads on shutdown to prevent hangs in sync XHR from unload

NEW
Unassigned

Status

()

Core
DOM
--
critical
2 years ago
2 years ago

People

(Reporter: BenWa, Unassigned)

Tracking

({crash})

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: btpp-backlog, crash signature)

(Reporter)

Description

2 years ago
This bug was filed from the Socorro interface and is 
report bp-ccc41702-dea7-4db7-8685-3a3462160311.
=============================================================

Looking at this report we're the website is doing a sync XHR from the unload event on shutdown. Hitting the network can take an arbitrary amount of time. This causes us to hit the shutdownhang code before the user has a tab that force an XHR request on shutdown.

We should consider giving website a budget for how much time they can spend in their unload before we move on. Ideally this would be a subset of the shutdownhang trigger time so that we can survive having at least a few bad apples before we take down the browser.
(Reporter)

Comment 1

2 years ago
khuey mentions that:
1) Web workers have some kind script timeout on shutdown.
2) We could abort network loads on shutdown.
Should we morph this into the budget or timeout ideas?
Flags: needinfo?(khuey)
Whiteboard: btpp-backlog
Sure, why not.
Flags: needinfo?(khuey)
Summary: crash in shutdownhang | ntdll.dll@0xa5154 | Hang in Sync XHR from unload on shutdown. → Abort network loads on shutdown to prevent hangs in sync XHR from unload
You need to log in before you can comment on or make changes to this bug.